Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parentheses notation should respect lifetime elision #18992

Closed
nikomatsakis opened this issue Nov 16, 2014 · 3 comments · Fixed by #19589
Closed

Parentheses notation should respect lifetime elision #18992

nikomatsakis opened this issue Nov 16, 2014 · 3 comments · Fixed by #19589
Labels
P-medium Medium priority

Comments

@nikomatsakis
Copy link
Contributor

HRTB doesn't correctly implement lifetime elision for Fn() notation. See the test src/test/compile-fail/unboxed-closure-sugar-equiv.rs.
@aturon aturon mentioned this issue Nov 16, 2014
Closed
47 tasks
@nikomatsakis
Copy link
Contributor Author

Nominating.

@pnkfelix
Copy link
Member

@alexcrichton notes that this can be fixed backwards compatibly, and @nikomatsakis agrees.

P-high, not 1.0.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Nov 20, 2014
@nikomatsakis
Copy link
Contributor Author

Well, sort of -- I mean lifetime elision broke code, but almost only bad code. The problem is that people can use transmute to satisfy the signature and then clients get to assume any lifetime they want.

huonw added a commit to huonw/rust that referenced this issue Dec 6, 2014
@huonw
Implement lifetime elision for Foo(...) -> ... type sugar.
b800ce1 
This means that `Fn(&A) -> (&B, &C)` is equivalent to `for<'a> Fn(&'a A)
-> (&'a B, &'a C)` similar to the lifetime elision of lower-case `fn` in
types and declarations.

Closes rust-lang#18992.
@huonw huonw mentioned this issue Dec 6, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 9, 2014
@alexcrichton
rollup merge of rust-lang#19589: huonw/unboxed-closure-elision
63ef9e9 
This means that `Fn(&A) -> (&B, &C)` is equivalent to `for<'a> Fn(&'a A)
-> (&'a B, &'a C)` similar to the lifetime elision of lower-case `fn` in
types and declarations.

Closes rust-lang#18992.
@nikomatsakis nikomatsakis mentioned this issue Jan 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement lifetime elision for Foo(...) -> ... type sugar. huonw/rust
2 participants
@nikomatsakis @pnkfelix