-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mk/tests.mk: find -perm +mode is deprecated #19981
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
Comments
Munksgaard
added a commit
to Munksgaard/rust
that referenced
this issue
Dec 18, 2014
The use of `+a+x` is deprecated. Fixes rust-lang#19981.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Dec 21, 2014
The use of `+a+x` is deprecated. Fixes rust-lang#19981.
Er, didn't actually land in the rollup, just didn't take the PR out of it, sorry! |
kmcallister
added
A-build
A-testsuite
Area: The testsuite used to check the correctness of rustc
labels
Jan 16, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Aug 11, 2015
New enough find on Linux doesn't support "-perm +..." and suggests using "-perm /..." instead, but that doesn't work on Windows. Hopefully all platforms are happy with this expanded version. I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging. Closes rust-lang#19981.
bors
added a commit
that referenced
this issue
Aug 13, 2015
New enough find on Linux doesn't support "-perm +..." and suggests using "-perm /..." instead, but that doesn't work on Windows. Hopefully all platforms are happy with this expanded version. I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging. Closes #19981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In mk/tests.mk we use the command
find -perm +a+x
to find executables. The syntax+a+x
has been deprecated since 2005 and have been removed from newer versions of find (mine isfind (GNU findutils) 4.5.14
), and should be replaced with/a+x
.The text was updated successfully, but these errors were encountered: