Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk/tests.mk: find -perm +mode is deprecated #19981

Closed
Munksgaard opened this issue Dec 18, 2014 · 1 comment · Fixed by #19983
Closed

mk/tests.mk: find -perm +mode is deprecated #19981

Munksgaard opened this issue Dec 18, 2014 · 1 comment · Fixed by #19983
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@Munksgaard
Copy link
Contributor

In mk/tests.mk we use the command find -perm +a+x to find executables. The syntax +a+x has been deprecated since 2005 and have been removed from newer versions of find (mine is find (GNU findutils) 4.5.14), and should be replaced with /a+x.

Munksgaard added a commit to Munksgaard/rust that referenced this issue Dec 18, 2014
alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 21, 2014
@alexcrichton
Copy link
Member

Er, didn't actually land in the rollup, just didn't take the PR out of it, sorry!

@alexcrichton alexcrichton reopened this Dec 22, 2014
@kmcallister kmcallister added A-build A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 16, 2015
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 11, 2015
New enough find on Linux doesn't support "-perm +..." and suggests
using "-perm /..." instead, but that doesn't work on Windows.
Hopefully all platforms are happy with this expanded version.

I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging.

Closes rust-lang#19981.
bors added a commit that referenced this issue Aug 13, 2015
New enough find on Linux doesn't support "-perm +..." and suggests
using "-perm /..." instead, but that doesn't work on Windows.
Hopefully all platforms are happy with this expanded version.

I don't have access to a Windows development system to test this, so someone needs to verify that this actually works there before merging.

Closes #19981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants