Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{:?} should not escape printable characters #22412

Closed
mahkoh opened this issue Feb 16, 2015 · 5 comments
Closed

{:?} should not escape printable characters #22412

mahkoh opened this issue Feb 16, 2015 · 5 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@mahkoh
Copy link
Contributor

mahkoh commented Feb 16, 2015

E.g. äöüß
@steveklabnik steveklabnik added A-libs C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Feb 16, 2015
@steveklabnik
Copy link
Member

/cc @aturon

@LukasKalbertodt
Copy link
Member

Currently escape_default is called for every character... I agree that the Debug output shouldn't escape printable characters. Although I think that it should escape C0 and C1 Control Characters. I guess that's what the user wants.
If anyone agrees I will fix that...

@LukasKalbertodt LukasKalbertodt mentioned this issue Mar 1, 2015
Closed
@aturon
Copy link
Member

aturon commented Mar 10, 2015

I'm on board with this, personally. @alexcrichton, @seanmonstar?

@alexcrichton
Copy link
Member

Sounds good to me

@seanmonstar
Copy link
Contributor

Me as well. One can always print as_bytes if they need to compare with
unicode symbols that look alike.

On Tue, Mar 10, 2015, 1:08 PM Alex Crichton notifications@github.com
wrote:

Sounds good to me

—
Reply to this email directly or view it on GitHub
#22412 (comment).

@mahkoh mahkoh closed this as completed Apr 11, 2015
@rust-lang rust-lang locked and limited conversation to collaborators Apr 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape control
6 participants
@steveklabnik @seanmonstar @alexcrichton @aturon @mahkoh @LukasKalbertodt