Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Add a generic string pattern matching API (RFC 528) #22477

Closed
aturon opened this issue Feb 18, 2015 · 6 comments
Closed

Tracking issue for Add a generic string pattern matching API (RFC 528) #22477

aturon opened this issue Feb 18, 2015 · 6 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. P-medium Medium priority T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@aturon
Copy link
Member

aturon commented Feb 18, 2015

rust-lang/rfcs#528
@aturon aturon added A-libs B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Feb 18, 2015
@aturon
Copy link
Member Author

aturon commented Feb 18, 2015

cc @Kimundi

Nominating for 1.0-beta P-high.

@aturon aturon mentioned this issue Feb 18, 2015
Merged
@pnkfelix
Copy link
Member

1.0 beta P-high

@pnkfelix pnkfelix added this to the 1.0 beta milestone Feb 26, 2015
@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Feb 26, 2015
@Kimundi
Copy link
Member

Kimundi commented Feb 26, 2015

Current status: A basic implementation landed, but there is still work to do:

  • remaining proposed methods need to be implemented
  • former optimizations need to be reimplemented (For example, the string search is currently naive and does needless bound checks)
  • some implemented things differ from the proposal
    • methods like match_indices might change their iterator type
    • the searcher traits should be namespaced to allow future replacement with HKT ones
  • Usage with methods like push or replace need to be evaluated, and a potential follow up RFC written

@pnkfelix
Copy link
Member

Remaining issues are not beta-blockers nor even 1.0 blockers. Reclassifying as P-high, not 1.0.

@pnkfelix pnkfelix removed this from the 1.0 beta milestone Mar 26, 2015
@Kimundi Kimundi mentioned this issue Apr 1, 2015
Merged
bors added a commit that referenced this issue Apr 7, 2015
@bors
Auto merge of #23952 - Kimundi:more_string_pattern, r=alexcrichton
b2e65ee 
This adds the missing methods and turns `str::pattern` in a user facing module, as per RFC.

This also contains some big internal refactorings:
- string iterator pairs are implemented with a central macro to reduce redundancy 
- Moved all tests from `coretest::str` into `collectionstest::str` and left a note to prevent the two sets of tests drifting apart further.

See #22477
@bluss
Copy link
Member

bluss commented Jul 5, 2015

Thanks kimundi for updating your status comment. It looks like this is as good as done — what remains is related followup.

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 11, 2015
@bluss bluss mentioned this issue Aug 16, 2015
Open
@alexcrichton
Copy link
Member

I'm going to close this in favor of the new tracking issue over at #27721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. P-medium Medium priority T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @pnkfelix @aturon @Kimundi @bluss