Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust_sched_loop shouldn't have logging-related functions #2495

Closed
brson opened this issue Jun 3, 2012 · 0 comments · Fixed by #2496
Closed

rust_sched_loop shouldn't have logging-related functions #2495

brson opened this issue Jun 3, 2012 · 0 comments · Fixed by #2496
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 3, 2012

Logging is unrelated to scheduling but rust_sched_loop has a log function that does things you would expect the logger to do.
brson added a commit that referenced this issue Jun 3, 2012
@brson
rt: Add a FIXME about #2495
35aa8d8
@brson brson mentioned this issue Jun 3, 2012
Merged
@arkaitzj arkaitzj mentioned this issue Jun 4, 2012
Merged
@brson brson closed this as completed in dad3007 Jun 4, 2012
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2495 - RalfJung:ra, r=RalfJung
ab88e64 
add ./miri cargo for RA to invoke

RA expects a check command to check *individual workspaces*, whereas `./miri` is designed to check/build/test all parts of Miri. So add a new `./miri cargo` that performs just a single cargo invocation, but with the right env vars so that the build cache can be shared with `./miri check`.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @zhassan-aws
Remove --harness requirement from stubbing (rust-lang#2495)
faa4086 
The compiler can now generate code for different combinations of harnesses with and without stubs. For that, we implemented a little state machine that may execute the underlying rust compiler multiple times. The first run is always for harnesses that don't have stub, while the subsequent runs are for harnesses with stubs.

Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved log method into logger class better than scheduler arkaitzj/rust
1 participant
@brson