Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In trans::type_use::mark_for_expr, don't count fields after the chosen field #2537

Closed
catamorphism opened this issue Jun 7, 2012 · 2 comments · Fixed by #9538 · May be fixed by devcode1981/rust#6 or MarcelRaschke/rust#6
Closed

In trans::type_use::mark_for_expr, don't count fields after the chosen field #2537

catamorphism opened this issue Jun 7, 2012 · 2 comments · Fixed by #9538 · May be fixed by devcode1981/rust#6 or MarcelRaschke/rust#6
Labels
A-codegen Area: Code generation

Comments

@catamorphism
Copy link
Contributor

(in an index or field expr). As per a FIXME.
@graydon
Copy link
Contributor

graydon commented Apr 24, 2013

bug is still relevant.

@emberian
Copy link
Member

emberian commented Jul 5, 2013

still relevvant

@Aatch Aatch mentioned this issue Aug 20, 2013
Closed
@thestinger thestinger mentioned this issue Sep 26, 2013
Merged
bors added a commit that referenced this issue Sep 27, 2013
@bors
auto merge of #9538 : thestinger/rust/type_use, r=pcwalton
ae8a2ff 
This is broken, and results in poor performance due to the undefined
behaviour in the LLVM IR. LLVM's `mergefunc` is a *much* better way of
doing this since it merges based on the equality of the bytecode.

For example, consider `std::repr`. It generates different code per
type, but is not included in the type bounds of generics.

The `mergefunc` pass works for most of our code but currently hits an
assert on libstd. It is receiving attention upstream so it will be
ready soon, but I don't think removing this broken code should wait any
longer. I've opened #9536 about enabling it by default.

Closes #8651
Closes #3547
Closes #2537
Closes #6971
Closes #9222
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 28, 2022
@bors
Auto merge of rust-lang#2537 - saethlin:dont-back-up-too-far, r=RalfJung
3e91125 
Don't back up past the caller when looking for an FnEntry span

Fixes rust-lang/miri#2536

This adds a fix for the logic as well as a regression test. In the new test `tests/fail/stacked_borrows/fnentry_invalidation2.rs`, before this PR, we display this diagnostic:
```
help: <3278> was later invalidated at offsets [0x0..0xc] by a Unique FnEntry retag
  --> tests/fail/stacked_borrows/fnentry_invalidation2.rs:13:5
   |
13 |     inner(&mut t);
   |     ^^^^^^^^^^^^^
```
Which is very misleading. It is not this call itself, but what happens within the call that invalidates the tag we want. With this PR, we get:
```
help: <2798> was later invalidated at offsets [0x0..0xc] by a Unique FnEntry retag inside this call
  --> tests/fail/stacked_borrows/fnentry_invalidation2.rs:20:13
   |
20 |     let _ = t.sli.as_mut_ptr();
   |             ^^^^^^^^^^^^^^^^^^
```
Which is much better.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 4, 2022
@bors
Auto merge of rust-lang#2537 - saethlin:dont-back-up-too-far, r=RalfJung
c217e07 
Don't back up past the caller when looking for an FnEntry span

Fixes rust-lang/miri#2536

This adds a fix for the logic as well as a regression test. In the new test `tests/fail/stacked_borrows/fnentry_invalidation2.rs`, before this PR, we display this diagnostic:
```
help: <3278> was later invalidated at offsets [0x0..0xc] by a Unique FnEntry retag
  --> tests/fail/stacked_borrows/fnentry_invalidation2.rs:13:5
   |
13 |     inner(&mut t);
   |     ^^^^^^^^^^^^^
```
Which is very misleading. It is not this call itself, but what happens within the call that invalidates the tag we want. With this PR, we get:
```
help: <2798> was later invalidated at offsets [0x0..0xc] by a Unique FnEntry retag inside this call
  --> tests/fail/stacked_borrows/fnentry_invalidation2.rs:20:13
   |
20 |     let _ = t.sli.as_mut_ptr();
   |             ^^^^^^^^^^^^^^^^^^
```
Which is much better.
This was referenced Oct 22, 2022
Open
Open
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@phayes
Update README.md - fix link locations for badge images in markdown (r…
94a7955 
…ust-lang#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation
Projects
None yet
Milestone
No milestone
3 participants
@graydon @catamorphism @emberian