Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite std::timer::recv_timeout more clearly #2618

Closed
catamorphism opened this issue Jun 15, 2012 · 1 comment
Closed

Rewrite std::timer::recv_timeout more clearly #2618

catamorphism opened this issue Jun 15, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

As per a FIXME. (Though I have to say, the use of the either::either combinator seems perfectly cromulent to me...)
@bblum
Copy link
Contributor

bblum commented Jun 10, 2013

I'd be more worried by the unsafe transmute-to-mut above, which originates from a bunch of places @Port can be generated in net_tcp.

But I understand timer and net_tcp are both deprecated pending #6435.

bblum added a commit to bblum/rust that referenced this issue Jun 11, 2013
@bblum
Remove 'this could be clearer' FIXME. Looks fine. Close rust-lang#2618.
d25fae0
@bblum bblum closed this as completed Jun 11, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 26, 2022
@bors
Auto merge of rust-lang#2618 - RalfJung:rustup, r=RalfJung
a46ccba 
Rustup
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2618 - RalfJung:rustup, r=RalfJung
a98e55e 
Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @bblum