Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some things don't implement IntoIterator #26220

Closed
Veedrac opened this issue Jun 11, 2015 · 4 comments
Closed

Some things don't implement IntoIterator #26220

Veedrac opened this issue Jun 11, 2015 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@Veedrac
Copy link
Contributor

Veedrac commented Jun 11, 2015

There are some missing IntoIterators:

  • By-reference and mut-reference for Option
  • By-reference and mut-reference for Result
  • By-reference for Path
  • Several misc. internal things (TraitObligationStackList, SearchPaths, ArchiveRO, RawTable, Book)

Given the by-value IntoIterator impls for Option and Result, I don't see why by-reference iteration would be special. Path should probably be IntoIterator. I'm indifferent with regards to internal stuff.
@apasel422
Copy link
Contributor

This was partially addressed by #28039.

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2015

internal things will only get impls when they are needed for internal purposes. e.g. TraitObligationStackList is only ever accessed by immutable reference.

@apasel422
Copy link
Contributor

CC @rust-lang/libs. The only outstanding part of this is &Path (and presumably &PathBuf).

@alexcrichton
Copy link
Member

Seems like an easy bug to knock out!

@alexcrichton alexcrichton added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Oct 30, 2015
@apasel422 apasel422 mentioned this issue Nov 1, 2015
Merged
bors added a commit that referenced this issue Nov 3, 2015
@bors
Auto merge of #29514 - apasel422:issue-26220, r=alexcrichton
3330f54 
Closes #26220.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @arielb1 @Veedrac @apasel422