Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_leaks unit test in core::run work on Windows #2626

Closed
catamorphism opened this issue Jun 15, 2012 · 2 comments
Closed

Make test_leaks unit test in core::run work on Windows #2626

catamorphism opened this issue Jun 15, 2012 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@catamorphism
Copy link
Contributor

It's currently ignored on Windows.

@Dretch
Copy link
Contributor

Dretch commented Apr 14, 2013

The code in question looks like:

// Regression test for memory leaks
#[ignore(cfg(windows))] // FIXME (#2626)
pub fn test_leaks() {
    run::run_program("echo", []);
    run::start_program("echo", []);
    run::program_output("echo", []);
}

When I commented-out the ignore and added a #[test] then this test passed on my Windows machine (Mingw32 + 64 bit Windows 7).

So perhaps this particular issue is no more?

bors added a commit that referenced this issue Apr 18, 2013
which does currently seem to work on win32 (and linux).

Just mentioning issue #2626 again to make sure github picks it up.
@alexcrichton
Copy link
Member

Fixed in #5912

RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 29, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

3 participants