Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rustc_unicode #26554

Closed
brson opened this issue Jun 24, 2015 · 2 comments
Closed

Rename rustc_unicode #26554

brson opened this issue Jun 24, 2015 · 2 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 24, 2015

Besides this (recently-renamed) library, all rustc_* crates are outside of the std facade. Every time I see this crate now I am confused of its role. If we don't want to take the unicode name then let's pick a different naming scheme that doesn't collide with the existing. Maybe std_unicode.

@brson brson added A-libs T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 24, 2015
@liigo
Copy link
Contributor

liigo commented Jun 28, 2015

It's not a fully function completed Unicode library, name it foo_unicode
will confuse people. Especially, std_unicode implying
standard/official/default unicode. Perhaps we should name it chars or
else, avoiding 'unicode'.
On Jun 25, 2015 07:26, "Brian Anderson" notifications@github.com wrote:

Besides this (recently-renamed) library, all rustc_* crates are outside
of the std facade. Every time I see this crate now I am confused of its
role. If we don't want to take the unicode name then let's pick a
different naming scheme that doesn't collide with the existing. Maybe
std_unicode.


Reply to this email directly or view it on GitHub
#26554.

@frewsxcv
Copy link
Member

Opened a PR for this: #38049.

frewsxcv added a commit to frewsxcv/rust that referenced this issue Nov 30, 2016
bors added a commit that referenced this issue Dec 12, 2016
Rename 'librustc_unicode' crate to 'libstd_unicode'.

Fixes #26554.
critiqjo pushed a commit to critiqjo/rustdoc that referenced this issue Dec 16, 2016
Rename 'librustc_unicode' crate to 'libstd_unicode'.

Fixes rust-lang/rust#26554.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants