Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SliceConcatExt::connect to join #26900

Closed
alexcrichton opened this issue Jul 8, 2015 · 3 comments
Closed

Rename SliceConcatExt::connect to join #26900

alexcrichton opened this issue Jul 8, 2015 · 3 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#1102
@alexcrichton alexcrichton added A-libs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Jul 8, 2015
@alexcrichton alexcrichton mentioned this issue Jul 8, 2015
Merged
@wesleywiser
Copy link
Member

Hi, I'd like to take this if that's OK.

Should I also change all of the places in this repo where .connect is called to call .join instead? Or does that break bootstrapping?

Thanks!

@alexcrichton
Copy link
Member Author

You should indeed! The stage0 libstd will have the rename so the bootstrap should be just fine (aka if make finishes then you're fine)

@wesleywiser
Copy link
Member

Thanks! I'm working on this now.

wesleywiser added a commit to wesleywiser/rust that referenced this issue Jul 10, 2015
@wesleywiser
Rename SliceConcatExt::connect to join rust-lang#26900
29c0c95
@wesleywiser wesleywiser mentioned this issue Jul 10, 2015
Merged
bors added a commit that referenced this issue Jul 12, 2015
@bors
Auto merge of #26957 - wesleywiser:rename_connect_to_join, r=alexcric…
05d8767 
…hton

Fixes #26900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @wesleywiser