Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize_next_sp might do better to allocate a new rust stack when returning to rust? #2698

Closed
graydon opened this issue Jun 21, 2012 · 5 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

Unclear fixme in rust_task.h. Might represent stack-switching bug or perf problem.

@bblum
Copy link
Contributor

bblum commented Jun 28, 2012

It'd be a perf problem the other way around - having crust calls always allocate new stack segments is worse than using existing ones. I tried that and it made crust-call-deep.rs regress.

As it is, it might put you into the redzone, but as long as the redzone is as big as it is, there's no problem. Leaving this open 'cause having a big redzone itself seems unpopular.

@nikomatsakis
Copy link
Contributor

Seems related to #2820

@bblum
Copy link
Contributor

bblum commented Jul 13, 2013

Renominating for production-ready; this is a runtime optimization, not a backward-compatibility issue.

This code will hopefully go away soon, but it will have to be reimplemented in the new runtime, so represents a decision we'll still have to make.

@graydon
Copy link
Contributor Author

graydon commented Jul 18, 2013

just a bug, removing milestone/nomination.

@alexcrichton
Copy link
Member

In today's meeting we have decided to jettison segmented stacks. I also don't think that this code exist any more, so closing.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 3, 2022
replace 'locally built rustc' instructions by 'Miri in rustc'
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
replace 'locally built rustc' instructions by 'Miri in rustc'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

4 participants