Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io::reader_util should be parameterized over readers #2903

Closed
eholk opened this issue Jul 13, 2012 · 2 comments
Closed

io::reader_util should be parameterized over readers #2903

eholk opened this issue Jul 13, 2012 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@eholk
Copy link
Contributor

eholk commented Jul 13, 2012 

impl reader_util for reader {
    ...
}

should be

impl<T: reader> reader_util for T {
    ...
}
@eholk eholk mentioned this issue Jul 13, 2012
Closed
@bblum
Copy link
Contributor

bblum commented Jul 16, 2012

Found during ICFP (#2928).

@Dretch
Copy link
Contributor

Dretch commented Mar 24, 2013

Given that ReaderUtil now looks like:

impl<T:Reader> ReaderUtil for T { ... }

Then I propose that this bug is fixed and can be closed.

@z0w0 z0w0 closed this as completed Jun 17, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 3, 2023
@bors
Auto merge of rust-lang#2903 - saethlin:rustup, r=RalfJung
7bef7b7 
rustup
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@github-actions
Automatic toolchain upgrade to nightly-2023-11-29 (rust-lang#2903)
aeafbd8 
Update Rust toolchain from nightly-2023-11-28 to nightly-2023-11-29
without any other source changes.
This is an automatically generated pull request. If any of the CI checks
fail, manual intervention is required. In such a case, review the
changes at https://github.com/rust-lang/rust from
rust-lang@49b3924
up to
rust-lang@5facb42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eholk @z0w0 @Dretch @bblum