Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Docs: path #29368

Closed
7 tasks
steveklabnik opened this issue Oct 26, 2015 · 5 comments
Closed
7 tasks

API Docs: path #29368

steveklabnik opened this issue Oct 26, 2015 · 5 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority

Comments

@steveklabnik
Copy link
Member

steveklabnik commented Oct 26, 2015

Part of #29329

http://doc.rust-lang.org/std/path/

Here's what's needed to close out this issue:

  • Components should use the standard iterator boilerplate.
  • Display needs some more explanation and a link to the display method.
  • Iter should use the standard iterator boilerplate.
  • PrefixComponent needs general expansion and examples
  • StripPrefixError needs a shorter summary and a link to the method it comes from.
  • Component shouldn't say to refer to the module, we should move most of its docs here.
  • Prefix could use more explanation, and is_verbatim needs an example.
@mgattozzi
Copy link
Contributor

@steveklabnik I'd be willing to help further document this module. Are there any trouble spots in particular that could use further clarification or items within the module that could use more documentation or examples?

@steveklabnik
Copy link
Member Author

@mgattozzi things I can see right now:

  1. some stuff could use examples, not just on the individual methods, but also generally
  2. https://doc.rust-lang.org/std/path/struct.Iter.html should link to the method that creates it, see the various iterator structs in std::iter for some boilerplate text.

@mgattozzi
Copy link
Contributor

Alright I'll start working on it this week. I'll link the branch I'll be working on here once I start so anyone can look at the progress, then put in a PR when it's ready.

@steveklabnik steveklabnik added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Mar 8, 2017
@steveklabnik
Copy link
Member Author

I am happy to mentor anyone who wants to tackle this issue.

@steveklabnik steveklabnik added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Mar 10, 2017
@steveklabnik steveklabnik added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. P-medium Medium priority and removed A-docs labels Mar 24, 2017
@chordowl
Copy link
Contributor

I'm gonna work on this one!

frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 18, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 18, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 18, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 19, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 19, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 19, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 20, 2017
Improve std::path docs

Fixes rust-lang#29368.

This PR contains a pretty significant redistribution of some of the module docs to more appropriate places, as well as general expansion, clarification, and additional examples.

For more details, see the commit descriptions.

r? @steveklabnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants