Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All vec.rs by-reference functions are unsafe. #3178

Closed
bblum opened this issue Aug 11, 2012 · 1 comment
Closed

All vec.rs by-reference functions are unsafe. #3178

bblum opened this issue Aug 11, 2012 · 1 comment
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@bblum
Copy link
Contributor

bblum commented Aug 11, 2012

For example, fn push<T>(&v: ~[const T], +initval: T) -- has a huge unsafe block inside, and might mutate the caller's "v" pointer.

This is... maybe safe today, but not in theory, and will break with rw_arcs (#3145).
@bblum
Copy link
Contributor Author

bblum commented Aug 11, 2012

Never mind; they are fine. Just be careful with them when converting away from argument modes.

@bblum bblum closed this as completed Aug 11, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@kestred @topecongiro
Trim the indentation on macros which heuristically appear to use bloc…
cd8bb50 
…k-style indentation (rust-lang#3178)
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@dependabot
Bump tests/perf/s2n-quic from 6dd41e0 to bd37960 (rust-lang#3178)
b612686 
Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
`6dd41e0` to `bd37960`.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/s2n-quic/commit/bd37960965d5bc8ab9990dc400c886a7a83fb57e"><code>bd37960</code></a>
feat(s2n-quic-rustls): update rustls from 0.21 to 0.23 (<a
href="https://github.com/aws/s2n-quic/issues/2200">#2200</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/286adde6279e33859e6118b4a83193ec620597e9"><code>286adde</code></a>
feat(s2n-quic): provider-crypto-fips feature flag (<a
href="https://github.com/aws/s2n-quic/issues/2194">#2194</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/c5ba08150c37cd31861181ceeb22e3e44fd7d254"><code>c5ba081</code></a>
chore(s2n-quic-core): update frame round trip fuzz corpus (<a
href="https://github.com/aws/s2n-quic/issues/2205">#2205</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/8c3248b65362d0c9bc00ac26e4bb56ca1385ff47"><code>8c3248b</code></a>
feat(s2n-quic-core): add state contstruction (<a
href="https://github.com/aws/s2n-quic/issues/2202">#2202</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/f05dc62ed872b4ae4ba6d73c4c502f0616ef612e"><code>f05dc62</code></a>
feat(s2n-quic-dc): DC_STATELESS_RESET_TOKENS frame (<a
href="https://github.com/aws/s2n-quic/issues/2198">#2198</a>)</li>
<li>See full diff in <a
href="https://github.com/aws/s2n-quic/compare/6dd41e09195bc22dbac93a48f8ab35f8063726dc...bd37960965d5bc8ab9990dc400c886a7a83fb57e">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bblum