Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make emacs rust-mode package.el compatible (marmalade/melpa) #3187

Closed
mpenet opened this issue Aug 12, 2012 · 0 comments
Closed

make emacs rust-mode package.el compatible (marmalade/melpa) #3187

mpenet opened this issue Aug 12, 2012 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@mpenet
Copy link
Contributor

mpenet commented Aug 12, 2012

This would make it a lot easier to install with package.el (from marmalade and melpa at least), and automate the byte-compilation.

This should follow the "marmalade package format" as described here http://marmalade-repo.org/doc-files/package.5.html . It is quite straightforward I believe, just adding a header/footer/dependencies and mark autoloads mostly.

I will give it a try when I get back later this week, if no one has done it first.

http://marmalade-repo.org/
http://melpa.milkbox.net/
This was referenced Aug 13, 2012
Closed
Closed
@mpenet mpenet closed this as completed Aug 14, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 25, 2023
@bors
Auto merge of rust-lang#3187 - RalfJung:rustup, r=RalfJung
807ba04 
Rustup
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 25, 2023
@bors
Auto merge of rust-lang#3187 - RalfJung:rustup, r=RalfJung
b7912d3 
Rustup
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@zhassan-aws
Include --check-cfg=cfg(kani) in the rust flags to avoid a warning …
9b9e473 
…about an unknown `cfg`. (rust-lang#3187)

Starting with the 2024-05-05 toolchain (and the upcoming Rust 1.80
release), the `unexpected_cfgs` lint has been turned on by default. As a
result, running `cargo kani` on a crate that has a `#[cfg(kani)]`
results in a warning (see rust-lang#3186). To avoid this warning, this PR adds
`--check-cfg=cfg(kani)` to `RUSTFLAGS` when Kani invokes `cargo`.

Call-outs: On such packages, doing a `cargo build` will also result in
this warning, unless:
```rust
println!("cargo::rustc-check-cfg=cfg(kani)");
```
is added to the package's `build.rs` file. However, this warning would
only occur with `cargo build` if the package uses the 2024-05-05
toolchain (or newer), or the Rust version used in the package is
upgraded to 1.80 (when it's released at the end of July 2024). Since
we're likely to release a new version of Kani sooner than the 1.80
release, this PR mitigates the issue that is more likely to impact users
(a warning from `cargo kani`).

Resolves rust-lang#3186 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpenet