Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved import in glob imported modules #32089

Closed
KyleMayes opened this issue Mar 7, 2016 · 3 comments · Fixed by #32097
Closed

Unresolved import in glob imported modules #32089

KyleMayes opened this issue Mar 7, 2016 · 3 comments · Fixed by #32097
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@KyleMayes
Copy link
Contributor

The latest nightly broke some imports in my project that were working previously.

Here is a minimal example (spread out over three files):

// src/lib.rs

mod one;
pub use self::one::*;

mod two;
pub use self::two::*;

pub type Type = i32;
// src/one.rs

use super::{Type};
// src/two.rs

use super::{Type};

The issue is only when there is more than one of these types of imports. I'm not sure if this is a bug or I have been relying on incorrect behavior until now.

Meta

rustc 1.9.0-nightly (52e0bda64 2016-03-05)
binary: rustc
commit-hash: 52e0bda644823089f16795cc9e071cf827b4810b
commit-date: 2016-03-05
host: x86_64-unknown-linux-gnu
release: 1.9.0-nightly
@retep998
Copy link
Member

retep998 commented Mar 7, 2016

This may be due to #31726

zitsen pushed a commit to zitsen/unqlite.rs that referenced this issue Mar 7, 2016
@alexcrichton
Copy link
Member

Indeed looks broken on nightly!

cc @jseyfried

@jseyfried
Copy link
Contributor

@KyleMayes Thanks for the report and minimal example. This is a bug.

This was caused by #31726. I diagnosed the problem and will fix it ASAP (~1 hr).

@alexcrichton alexcrichton added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Mar 7, 2016
bors added a commit that referenced this issue Mar 10, 2016
…sakis

Fix a regression in import resolution

This fixes #32089 (caused by #31726) by deducing that name resolution has failed (as opposed to being determinate) in more cases.

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants