str::to_owned doesn't generate exactly the same code as String::from #32163
Labels
A-codegen
Area: Code generation
Comments
bors
added a commit
that referenced
this issue
Mar 13, 2016
Call str::to_owned in String::from and uninline it Call str::to_owned in String::from and uninline it These methods were already effectively equal, but now one calls the other, and neither is marked inline. String::from does not need to be inlined, it can be without it just like str::to_owned and String::clone are. Fixes #32163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
to_ownedis not marked#[inline]whileString::fromis. Check the assembly, one is inlined and the other isn't. It probably doesn't matter and in fact I can't measure any performance difference with short strings (and long ones are probably dominated by the memcpy anyway). Maybe we should just stop inliningfromto make binaries a tiny bit smaller. Either way, it's unfortunate that these two conversion methods, which are often described as being exactly equivalent, aren't.The text was updated successfully, but these errors were encountered: