Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source archives should contain Git commit hash and date #32444

Closed
nodakai opened this issue Mar 23, 2016 · 2 comments
Closed

Source archives should contain Git commit hash and date #32444

nodakai opened this issue Mar 23, 2016 · 2 comments
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. P-low Low priority

Comments

@nodakai
Copy link
Contributor

nodakai commented Mar 23, 2016

Can we include the output of git log -1 into the source archives? It can be important for beta and nightly.

Ideally the download page should also display them.

@brson brson added the P-low Low priority label Aug 22, 2016
@alexcrichton alexcrichton added the E-help-wanted Call for participation: Help is requested to fix this issue. label Aug 22, 2016
@alexcrichton
Copy link
Member

This should be a pretty easy bug to tackle for anyone aspiring to do so. Let's just create a file called VERSION in our tarballs with basically the output of rustc -v

@brson
Copy link
Contributor

brson commented Aug 26, 2016

This will require editing the makefiles in mk/dist.mk as well as the rustbuild build system in src/rustbuild. The version info is in CFG_VERSION. I realized that the installers already include this info in a file called 'version', so we can just duplicate that logic. Use the same lower case naming for consistency.

bors added a commit that referenced this issue Sep 16, 2016
Add rustc version info (git hash + date) to dist tarball

a fix for #32444
@bors bors closed this as completed in 72da8b8 Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. P-low Low priority
Projects
None yet
Development

No branches or pull requests

4 participants