Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve concurrency example so that it actually is a data race #32733

Closed
Manishearth opened this issue Apr 4, 2016 · 1 comment
Closed

Improve concurrency example so that it actually is a data race #32733

Manishearth opened this issue Apr 4, 2016 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@Manishearth
Copy link
Member

See discussion on #32538

https://github.com/rust-lang/rust/blob/master/src/doc/book/concurrency.md#safe-shared-mutable-state provides a program that could have a data race, but doesn't -- each thread accesses an independent array member.

We should use a program that does in fact have a data race; perhaps something that iterates over the same array twice or accesses random keys.
@Manishearth Manishearth added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Apr 4, 2016
@allonsy allonsy mentioned this issue Apr 8, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 10, 2016
@Manishearth
Rollup merge of rust-lang#32815 - allonsy:master, r=GuillaumeGomez
99850cc 
Adds data race in docs

Thanks for all your hard work!
This is in reference to rust-lang#32733
I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in.
Let me know what you think and/or if you want me to modify anything!
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 11, 2016
@steveklabnik
Rollup merge of rust-lang#32815 - allonsy:master, r=GuillaumeGomez
b5fc27c 
Adds data race in docs

Thanks for all your hard work!
This is in reference to rust-lang#32733
I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in.
Let me know what you think and/or if you want me to modify anything!
@apasel422
Copy link
Contributor

This appears to have been fixed in #32815.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @Manishearth @apasel422