Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.. in tuple-like patterns (tracking issue for RFC 1492) #33627

Closed
nikomatsakis opened this issue May 13, 2016 · 8 comments
Closed

.. in tuple-like patterns (tracking issue for RFC 1492) #33627

nikomatsakis opened this issue May 13, 2016 · 8 comments
Labels
B-RFC-implemented Blocker: Approved by a merged RFC and implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Tracking issue for rust-lang/rfcs#1492
@nikomatsakis nikomatsakis added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-lang Relevant to the language team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels May 13, 2016
@nikomatsakis nikomatsakis mentioned this issue May 13, 2016
Merged
@petrochenkov
Copy link
Contributor

I'll rebase #32079 this weekend.

@petrochenkov petrochenkov mentioned this issue May 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue May 26, 2016
@Manishearth
Rollup merge of rust-lang#33639 - petrochenkov:dotdot, r=nmatsakis
170c438 
 cc rust-lang#33627
r? @nikomatsakis

plugin-[breaking-change] cc rust-lang#31645 @Manishearth
Manishearth added a commit to Manishearth/rust that referenced this issue May 27, 2016
@Manishearth
Rollup merge of rust-lang#33639 - petrochenkov:dotdot, r=nmatsakis
3578571 
 cc rust-lang#33627
r? @nikomatsakis

plugin-[breaking-change] cc rust-lang#31645 @Manishearth
@petrochenkov
Copy link
Contributor

I don't see neither anything preventing stabilization of this feature, nor strong motivation to stabilize it immediately.
.. currently works in beta (1.11) and nightly (1.12), I suggest to stabilize it in in 1.13 (the next cycle), unless someone want it sooner or has reservations.

@nrc nrc added B-RFC-implemented Blocker: Approved by a merged RFC and implemented. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Aug 29, 2016
@petrochenkov petrochenkov mentioned this issue Sep 1, 2016
Merged
bors added a commit that referenced this issue Sep 4, 2016
@bors
Auto merge of #36203 - petrochenkov:uvsdot, r=nrc
91f057d 
Replace `_, _` with `..` in patterns

This is how #33627 looks in action.

Looks especially nice in leftmost/rightmost positions `(first, ..)`/`(.., last)`.
I haven't touched libsyntax intentionally because the feature is still unstable.
@petrochenkov petrochenkov mentioned this issue Sep 29, 2016
Merged
@nikomatsakis
Copy link
Contributor Author

@rfcbot fcp merge

I propose that we stabilize this feature. There are no known blockers or interactions and it is a minor extension to existing syntax.

@rfcbot
Copy link

rfcbot commented Oct 4, 2016 •
edited
Loading

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link

rfcbot commented Oct 13, 2016

All relevant subteam members have reviewed. No concerns remain.

@rfcbot
Copy link

rfcbot commented Oct 20, 2016

It has been one week since all blocks to the FCP were resolved.

@aturon aturon added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Oct 22, 2016
@aturon
Copy link
Member

aturon commented Oct 22, 2016

🔔 This feature is undergoing its final comment period with disposition to stabilize 🔔

@nikomatsakis
Copy link
Contributor Author

The release is coming up, and this has not exactly been a controversial topic, so we've decide to make it official and approve this for stabilization.

@nikomatsakis nikomatsakis removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Nov 2, 2016
bors added a commit that referenced this issue Nov 8, 2016
@bors
Auto merge of #36843 - petrochenkov:dotstab, r=nikomatsakis
722c687 
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
bors added a commit that referenced this issue Nov 8, 2016
@bors
Auto merge of #36843 - petrochenkov:dotstab, r=nikomatsakis
38a959a 
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
@Eh2406 Eh2406 mentioned this issue Jan 27, 2017
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-implemented Blocker: Approved by a merged RFC and implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nikomatsakis @aturon @nrc @petrochenkov @rfcbot