Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing issue #36556

Closed
pmarcelll opened this issue Sep 18, 2016 · 5 comments
Closed

Licensing issue #36556

pmarcelll opened this issue Sep 18, 2016 · 5 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@pmarcelll
Copy link
Contributor

The files src/libstd/sync/mpsc/spsc_queue.rs and src/libstd/sync/mpsc/spsc_queue.rs was originally added a long time ago in #10080, and the first line is Copyright (c) 2010-2011 Dmitry Vyukov. All rights reserved. (explained in #9710). These files are only licensed under the BSD 2-Clause license.

  • The file doesn't contain the usual Copyright The Rust Developers, although the team is a co-author.
  • Does the second clause means, that rustc should print the whole BSD license just for these? (Or I'm misinterpreting it?)

Is it an issue at all? (I'm not that familiar with distributing and licensing software.) If it is, can we do something about it?

@bstrie bstrie added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 18, 2016
@Mark-Simulacrum
Copy link
Member

cc @brson because this is a licensing question

@aturon
Copy link
Member

aturon commented May 17, 2017

cc @rust-lang/core

@alexcrichton
Copy link
Member

I believe we just need to add this to the COPYRIGHT file in the root of the repository, and that should do the trick! (this is similar to jemalloc)

@pmarcelll
Copy link
Contributor Author

Thanks for looking into this issue!
The code comes from #9710, from the first comment:

I included the license Dmitry asked me to use when I implemented a C++11 version of this queue a while ago. If the license is an issue, I suggest reaching out to Dmitry.

So I guess it's worth asking him, he's active on Github.

@dvyukov with all due respect, can you help us resolve this issue? The real issue is that the code in question has a different license than the rest of the codebase (although the Apache2/MIT dual license is very similar to the BSD license).

dvyukov added a commit to dvyukov/rust that referenced this issue May 22, 2017
These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
@brson
Copy link
Contributor

brson commented May 22, 2017

I think it is not a problem that these files are BSD licensed - rust carries a bunch of licenses, including BSD, but it wouldn't hurt to relicense them.

Well, actually, if this is the only BSD code in std (I don't know if that's the case), then removing the BSD license would reduce the burden on those redistributing std.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 23, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 24, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 24, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 24, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 25, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 25, 2017
libstd/sync/mpsc: relicense under rust license

These files are licensed under a different license
than the rest of the codebase. This causes potential
issues and inconveniences.
Relicense these files under the standard license.
I hold original copyright on that code.

Fixes rust-lang#36556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants