Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tidy: skip check for binaries if /proc/version contains the string Microsoft #36706

Closed
ahicks92 opened this issue Sep 25, 2016 · 0 comments

Comments

@ahicks92
Copy link
Contributor

If developing under Windows Subsystemm for Linux, make tidy mistakenly believes that all source files are binaries. Per @eddyb's comment in #36151, this is likely to be because all files on the Windows filesystem are exposed with permissions 777.

We can detect that a system is likely to be WSl by checking /proc/version for the string Microsoft. should Microsoft ever change this file to not use this string, the worst that happens here is a regression. It is possible that other Linux systems include the string Microsoft in /proc/version, but this seems unlikely.

The specific problem here is twofold: make tidy prints binary checked into source for every single file in the repository, and make check refuses to run because make tidy fails. I'm not familiar enough with the Rust build system to even begin to attempt to fix this myself.

bors added a commit that referenced this issue Sep 25, 2016
Skip binary tidy check when on Windows Linux Subsystem

While it's possible that other linux systems will include "Microsoft" in
their /proc/version, this is deemed unlikely, and since this is a tidy
check, will likely be caught by buildbot/travis either way.

Fixes #36706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant