You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If developing under Windows Subsystemm for Linux, make tidy mistakenly believes that all source files are binaries. Per @eddyb's comment in #36151, this is likely to be because all files on the Windows filesystem are exposed with permissions 777.
We can detect that a system is likely to be WSl by checking /proc/version for the string Microsoft. should Microsoft ever change this file to not use this string, the worst that happens here is a regression. It is possible that other Linux systems include the string Microsoft in /proc/version, but this seems unlikely.
The specific problem here is twofold: make tidy prints binary checked into source for every single file in the repository, and make check refuses to run because make tidy fails. I'm not familiar enough with the Rust build system to even begin to attempt to fix this myself.
The text was updated successfully, but these errors were encountered:
Skip binary tidy check when on Windows Linux Subsystem
While it's possible that other linux systems will include "Microsoft" in
their /proc/version, this is deemed unlikely, and since this is a tidy
check, will likely be caught by buildbot/travis either way.
Fixes#36706.
If developing under Windows Subsystemm for Linux,
make tidy
mistakenly believes that all source files are binaries. Per @eddyb's comment in #36151, this is likely to be because all files on the Windows filesystem are exposed with permissions 777.We can detect that a system is likely to be WSl by checking
/proc/version
for the stringMicrosoft
. should Microsoft ever change this file to not use this string, the worst that happens here is a regression. It is possible that other Linux systems include the stringMicrosoft
in/proc/version
, but this seems unlikely.The specific problem here is twofold:
make tidy
printsbinary checked into source
for every single file in the repository, andmake check
refuses to run becausemake tidy
fails. I'm not familiar enough with the Rust build system to even begin to attempt to fix this myself.The text was updated successfully, but these errors were encountered: