make install doesn't work correctly with relative directory prefixes
#36989
Comments
|
I think this is still an issue with rustbuild, but should be somewhat easy to fix.. I think we just want to call canonicalize on the paths here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/install.rs#L41. @alexcrichton Does that sound correct to you? If so, this is E-easy and E-mentor (by me). |
|
I believe so! |
alexcrichton
added
E-easy
|
@alexcrichton @Mark-Simulacrum I can take a crack at this one if nobody else has started on it yet. |
|
Go ahead! Let us know if there's anything we can do to help you. |
Mark-Simulacrum
added
T-dev-tools
Mark-Simulacrum
added
C-enhancement
|
Just an update - still working on this, just got buried in a move. Will try to get it knocked out this week. |
|
@Mark-Simulacrum @alexcrichton are there any unit-like tests that run against the install scripts? or do they just get tested as part of the full build? |
|
No unfortunately I don't think we test this step at all on CI :( |
Testing: ``` $ git diff diff --git a/config.toml.example b/config.toml.example index 9dd3002506..b47bc490cd 100644 --- a/config.toml.example +++ b/config.toml.example @@ -196,7 +196,7 @@ [install] # Instead of installing to /usr/local, install to this path instead. -#prefix = "/usr/local" +prefix = "install-prefix" # Where to install system configuration files # If this is a relative path, it will get installed in `prefix` above $ mkdir install-prefix $ ./x.py install -i --stage 0 --config config.toml.example ... $ ls install-prefix/ bin lib share ``` Closes rust-lang#36989.
rustbuild: canonicalize prefix `install_sh` Testing: ``` $ git diff diff --git a/config.toml.example b/config.toml.example index 9dd3002506..b47bc490cd 100644 --- a/config.toml.example +++ b/config.toml.example @@ -196,7 +196,7 @@ [install] # Instead of installing to /usr/local, install to this path instead. -#prefix = "/usr/local" +prefix = "install-prefix" # Where to install system configuration files # If this is a relative path, it will get installed in `prefix` above $ mkdir install-prefix $ ./x.py install -i --stage 0 --config config.toml.example ... $ ls install-prefix/ bin lib share ``` Closes #36989. r? @Mark-Simulacrum
|
canonicalizing the prefix breaks when prefix is a symbolic link. e.g., /usr/local -> /some/other/location Now if you want to install to /usr/local, everything goes to /some/other/location instead with many files including references to /some/other/location internally. Now when I want to change the /usr/local sym link (in my case, the underlying location is a shared NFS mount point) to point to /a/different/location that contains the rust install, all the references to /some/other/location are wrong - leaving the best remaining option to recompile rust (and that's painful) on each occurrence where the underlying path pointed to by is different. There must be a better way to solve the relative path issue than by manually converting all sym links to their resolved paths. I can't think of any packages right now where defining prefix to a sym link breaks in this way. |
When I configured with
--prefix=install-prefixand ranmake install, my install ended up in./tmp/empty_dir/install-prefix.The text was updated successfully, but these errors were encountered: