Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove front::intrinsic::get_tydesc #3727

Closed
catamorphism opened this issue Oct 11, 2012 · 4 comments
Closed

Remove front::intrinsic::get_tydesc #3727

catamorphism opened this issue Oct 11, 2012 · 4 comments
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

As per FIXME: "remove this when the interface has settled and the
// version in sys is no longer present." The version in sys is still used, so this can't be removed yet.

@graydon
Copy link
Contributor

graydon commented Jan 27, 2013

See also #3475

@luqmana
Copy link
Member

luqmana commented Feb 13, 2013

So is it that neither is one wanted or could you keep only the one in sys and remove all uses of intrinsic::TyDesc in favour of sys::TypeDesc. As well as move the TyVisitor to core::sys which basically gets rid of librustc/front/intrinsic.rs altogether.

graydon added a commit to graydon/rust that referenced this issue Feb 26, 2013
@catamorphism
Copy link
Contributor Author

Doesn't seem critical for 0.6. De-milestoning

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Seems to have been fixed. The fixme is certainly gone.

@emberian emberian closed this as completed Aug 5, 2013
bors added a commit that referenced this issue Feb 3, 2019
submodule: update clippy from 6ce78d1 to 3bda548

rust-lang/rust-clippy@6ce78d1...3bda548

Rustup: unused trim result
Auto merge of #3727 - phansch:rustup_unused_trim, r=matthiaskrgr  …
Travis: Don't run integration tests on every PR commit  …
Auto merge of #3726 - phansch:some_renaming, r=oli-obk  …
Fix ICE in vec_box lint and add run-rustfix  …
Make vec_box MachineApplicable
Remove conditionals from base builds  …
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100.  …
Running util/dev to update README/CHANGELOG
Reworking function logic, and adding doc example.  …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Skipping check if in external macro.
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100.  …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Changing single character string to a character match.
Updated readme.
Updating code to ignore rustfmt issue.
phansch and avborhanian
Update clippy_lints/src/types.rs  …
Update clippy_lints/src/types.rs  …
Auto merge of #3732 - phansch:fix_ice_3720, r=oli-obk  …
Auto merge of #3731 - phansch:travis, r=phansch  …
Auto merge of #2857 - avborhanian:master, r=phansch  …
Fix breakage due to #58079  …
Auto merge of #3736 - mikerite:fix-build-20190203, r=phansch  …

related with: #58024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

4 participants