Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Windows subsystem support #37499

Closed
alexcrichton opened this issue Oct 31, 2016 · 10 comments
Closed

Tracking issue for Windows subsystem support #37499

alexcrichton opened this issue Oct 31, 2016 · 10 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#1665
@alexcrichton alexcrichton added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-tools labels Oct 31, 2016
@alexcrichton alexcrichton mentioned this issue Oct 31, 2016
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Oct 31, 2016
@alexcrichton
rustc: Add knowledge of Windows subsystems.
20c3013 
This commit is an implementation of [RFC 1665] which adds support for the
`#![windows_subsystem]` attribute. This attribute allows specifying either the
"windows" or "console" subsystems on Windows to the linker.

[RFC 1665]: https://github.com/rust-lang/rfcs/blob/master/text/1665-windows-subsystem.md

Previously all Rust executables were compiled as the "console" subsystem which
meant that if you wanted a graphical application it would erroneously pop up a
console whenever opened. When compiling an application, however, this is
undesired behavior and the "windows" subsystem is used instead to have control
over user interactions.

This attribute is validated, but ignored on all non-Windows platforms.

cc rust-lang#37499
@alexcrichton alexcrichton mentioned this issue Oct 31, 2016
Merged
@liigo liigo mentioned this issue Nov 3, 2016
Closed
@tomaka tomaka mentioned this issue Nov 3, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this issue Nov 4, 2016
Rollup merge of rust-lang#37501 - alexcrichton:windows-subsystem, r=b…
f625f74 
…rson

rustc: Add knowledge of Windows subsystems.

This commit is an implementation of [RFC 1665] which adds support for the
`#![windows_subsystem]` attribute. This attribute allows specifying either the
"windows" or "console" subsystems on Windows to the linker.

[RFC 1665]: https://github.com/rust-lang/rfcs/blob/master/text/1665-windows-subsystem.md

Previously all Rust executables were compiled as the "console" subsystem which
meant that if you wanted a graphical application it would erroneously pop up a
console whenever opened. When compiling an application, however, this is
undesired behavior and the "windows" subsystem is used instead to have control
over user interactions.

This attribute is validated, but ignored on all non-Windows platforms.

cc rust-lang#37499
alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 4, 2016
@alexcrichton
Rollup merge of rust-lang#37501 - alexcrichton:windows-subsystem, r=b…
1a11cfa 
…rson

rustc: Add knowledge of Windows subsystems.

This commit is an implementation of [RFC 1665] which adds support for the
`#![windows_subsystem]` attribute. This attribute allows specifying either the
"windows" or "console" subsystems on Windows to the linker.

[RFC 1665]: https://github.com/rust-lang/rfcs/blob/master/text/1665-windows-subsystem.md

Previously all Rust executables were compiled as the "console" subsystem which
meant that if you wanted a graphical application it would erroneously pop up a
console whenever opened. When compiling an application, however, this is
undesired behavior and the "windows" subsystem is used instead to have control
over user interactions.

This attribute is validated, but ignored on all non-Windows platforms.

cc rust-lang#37499
alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 5, 2016
@alexcrichton
Rollup merge of rust-lang#37501 - alexcrichton:windows-subsystem, r=b…
8a38b24 
…rson

rustc: Add knowledge of Windows subsystems.

This commit is an implementation of [RFC 1665] which adds support for the
`#![windows_subsystem]` attribute. This attribute allows specifying either the
"windows" or "console" subsystems on Windows to the linker.

[RFC 1665]: https://github.com/rust-lang/rfcs/blob/master/text/1665-windows-subsystem.md

Previously all Rust executables were compiled as the "console" subsystem which
meant that if you wanted a graphical application it would erroneously pop up a
console whenever opened. When compiling an application, however, this is
undesired behavior and the "windows" subsystem is used instead to have control
over user interactions.

This attribute is validated, but ignored on all non-Windows platforms.

cc rust-lang#37499
@yasammez
Copy link

yasammez commented Nov 6, 2016

Not sure if this is the right place to comment, but since the RFC is already closed, I don't know where else to put it: a future inclusion of the native subsystem would enable us to write Windows kernel mode drivers. And ring 0 is really, where all that safety comes in handy ;-)

@alexcrichton alexcrichton added B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Nov 6, 2016
@chriskrycho
Copy link
Contributor

Has this been stabilized? It doesn't appear in the release notes for 1.13.0 or 1.14.0 (the releases since the last commits and actions on this).

@alexcrichton
Copy link
Member Author

@chriskrycho this has not yet been stabilized, no

@chriskrycho
Copy link
Contributor

@alexcrichton thanks for the clarification! I've written it up as to-be-documented over on #38643 accordingly. (And presumably we'd catch it anyway, but I wanted to be exhaustive.)

@alexcrichton
Copy link
Member Author

This seems like it's baked long enough and we haven't seen many changes, so I'd like to propose we stabilize it! To that end...

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 2, 2017 •
edited by brson
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@brson
Copy link
Contributor

brson commented Mar 16, 2017

We should consider backporting to 1.17.

@rfcbot
Copy link

rfcbot commented Mar 16, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

1 similar comment
@rfcbot
Copy link

rfcbot commented Mar 16, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Mar 16, 2017
This was referenced Mar 20, 2017
Merged
Closed
@rfcbot
Copy link

rfcbot commented Mar 26, 2017

The final comment period is now complete.

@alexcrichton alexcrichton mentioned this issue Mar 27, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 1, 2017
@alexcrichton
rustc: Stabilize the #![windows_subsystem] attribute
34cf288 
This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 2, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
aaade9a 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 2, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
69dfab8 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 3, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
810eb03 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 3, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
9fd0a18 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 3, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
3b1f3f0 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 4, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
8aa3494 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 4, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
ae3ad90 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
14a7dd4 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 5, 2017
@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
0239880 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
@Xaeroxe Xaeroxe mentioned this issue Dec 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @brson @chriskrycho @yasammez @rfcbot