Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation warning for --crate-type=metadata #38640

Closed
nrc opened this issue Dec 27, 2016 · 2 comments
Closed

Remove deprecation warning for --crate-type=metadata #38640

nrc opened this issue Dec 27, 2016 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nrc
Copy link
Member

nrc commented Dec 27, 2016 •
edited by nikomatsakis
Loading

UPDATE: Very easy way first bug! Mentoring instructions here.

This didn't spend long in the wild, so we don't need to wait too long. But, Cargo does rely on the flag, so we should leave it in at least long enough to fix Cargo and for people to upgrade.
@Mark-Simulacrum
Copy link
Member

It's been 5 months; nominating for compiler team discussion to remove --crate-type=metadata.

@Mark-Simulacrum Mark-Simulacrum added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 18, 2017
@nikomatsakis
Copy link
Contributor

Let's remove it! All it takes, I believe, is to kill this snippet of code found here.

@nikomatsakis nikomatsakis added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed I-nominated labels May 26, 2017
@citizen428 citizen428 mentioned this issue May 28, 2017
Merged
citizen428 added a commit to citizen428/rust that referenced this issue May 29, 2017
@citizen428
Remove --crate-type=metadata deprecation warning
9873acc 
Fixes rust-lang#38640
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 31, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42277 - citizen428:remove-crate-type-metada…
0daa27f 
…ta, r=nikomatsakis

Remove --crate-type=metadata deprecation warning

Fixes rust-lang#38640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @nrc @Mark-Simulacrum