-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hundreds of ignore'd tests are bitrotting in the test suite #3965
Comments
I'll see how far I can get with this. |
Down to 217! This can be an ongoing "brain is too dead to do anything else" project. |
Down to 140, not counting ones that are marked Nominating for milestone 4, "well-covered". This could be an easy starter project for many people: pick a few tests that are xfailed, and either fix them so they work, or file a bug saying that the test is still broken. |
I have been suggested this bug by cmr on IRC as a very good first bug as it shall enable me to see lot of code and I wish to work on this |
@rajul-iitkgp be warned, this may not be so simple. You must be very careful to ensure that every test is still exercising the same code paths today as it was originally. In addition, many concepts from ancient Rust have no direct equivalent in modern Rust. Some tests may simply not be salvageable and may need to be deleted. When in doubt, ask a developer. |
Up to 374 ;( |
accepted for well-covered milestone |
What is the right thing to do with xfailed tests that are for issues that have been closed as won't fix? Additionally, there are (well, at least one) tests that are xfailed because they aren't tests. For example, run-pass/mod_file_aux.rs, which says |
The test files like As for tests like issue-912.rs, I think that the idea here is to update as many as possible to the current "today syntax" while jettisoning those which are broken beyond repair or are simply never going to get fixed. For the one in the case of 912, it sounds like it just needs to get removed. |
Assigning P-low. |
|
|
cc #13745 |
Looking at my previous attempts to tackle this issue, I now realize that my regular expression may have been a bit too lose: we have In that case,
Still a ways to go, but much shorter :) |
Most of these are old, but some specific messages for specific tests: * trait-contravariant-self.rs: failed due to a soundess hole: rust-lang@05e3248 * process-detatch: rust-lang@15966c3 says "this test is being ignored until signals are implemented" That's not happening for a long time, and when it is, we'll write tests for it. * deep-vector{,2}.rs: "too big for our poor macro infrastructure", and has been ignored over a year. * borrowck-nested-calls.rs's FIXME rust-lang#6268 was closed in favor of rust-lang/rfcs#811 * issue-15167.rs works properly now * issue-9737.rs works properly now * match-var-hygiene.rs works properly now Addresses a chunk of rust-lang#3965
@steveklabnik I think this issue is asking for a systematic way to keep these tests from rotting. In the rspec terminology these tests are currently skipped, while they should be pending. |
now outputs
|
git grep -l xfail -- src/test/ | wc -l
shows 235 xfail'd tests. Some of these are using ancient language features; e.g. https://github.com/mozilla/rust/blob/master/src/test/run-fail/too-much-recursion-unwinding.rs is still making use of classes. Surely some of these tests can be updated and made to work with the current compiler.The text was updated successfully, but these errors were encountered: