Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE building protobuf-json-0.1.0, Rust 1.16 beta #39823

Closed
brson opened this issue Feb 14, 2017 · 3 comments · Fixed by #40064
Closed

ICE building protobuf-json-0.1.0, Rust 1.16 beta #39823

brson opened this issue Feb 14, 2017 · 3 comments · Fixed by #40064
Assignees
@arielb1
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 14, 2017

https://github.com/mrjones/rust-protobuf-json 5dbb6be3e4fed92ede0c5ddc9e5a0560ef27e0f8

brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +beta -Vv
rustc 1.16.0-beta.1 (5276ba72e 2017-01-31)
binary: rustc
commit-hash: 5276ba72e8fe13597200254447fce9cb3783c583
commit-date: 2017-01-31
host: x86_64-unknown-linux-gnu
release: 1.16.0-beta.1
LLVM version: 3.9

101 brian@ip-10-145-43-250:~/dev/rust-protobuf-json⟫ cargo +beta test
   Compiling protobuf v1.2.1
   Compiling serde v0.9.7
   Compiling dtoa v0.4.1
   Compiling itoa v0.3.1
   Compiling num-traits v0.1.36
   Compiling serde_json v0.9.6
   Compiling protobuf-json v0.2.0 (file:///mnt2/dev/rust-protobuf-json)
error: internal compiler error: /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc_trans/collector.rs:702: Cannot create local trans-item for DefId { krate: CrateNum(13), node: DefIndex(2720) => serde_json/d2f2c5cb81f8962426114e6f1be74067::value[0]::Value[0]::Bool[0] }

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

thread 'rustc' panicked at 'Box<Any>', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc_errors/lib.rs:416
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: Could not compile `protobuf-json`.
Build failed, waiting for other jobs to finish...
warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1597:29
     |
1597 |                 fields.push(::protobuf::reflect::accessor::make_repeated_f64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1601:29
     |
1601 |                 fields.push(::protobuf::reflect::accessor::make_repeated_f64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1605:29
     |
1605 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i32_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1609:29
     |
1609 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1613:29
     |
1613 |                 fields.push(::protobuf::reflect::accessor::make_repeated_u32_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1617:29
     |
1617 |                 fields.push(::protobuf::reflect::accessor::make_repeated_u64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1621:29
     |
1621 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i32_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1625:29
     |
1625 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1629:29
     |
1629 |                 fields.push(::protobuf::reflect::accessor::make_repeated_u32_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1633:29
     |
1633 |                 fields.push(::protobuf::reflect::accessor::make_repeated_u64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1637:29
     |
1637 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i32_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1641:29
     |
1641 |                 fields.push(::protobuf::reflect::accessor::make_repeated_i64_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1645:29
     |
1645 |                 fields.push(::protobuf::reflect::accessor::make_repeated_bool_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1649:29
     |
1649 |                 fields.push(::protobuf::reflect::accessor::make_repeated_string_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1653:29
     |
1653 |                 fields.push(::protobuf::reflect::accessor::make_repeated_bytes_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1657:29
     |
1657 |                 fields.push(::protobuf::reflect::accessor::make_repeated_message_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: use of deprecated item, #[warn(deprecated)] on by default
    --> src/tests/test_proto.rs:1661:29
     |
1661 |                 fields.push(::protobuf::reflect::accessor::make_repeated_enum_accessor(
     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: internal compiler error: /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc_trans/collector.rs:702: Cannot create local trans-item for DefId { krate: CrateNum(13), node: DefIndex(2720) => serde_json/d2f2c5cb81f8962426114e6f1be74067::value[0]::Value[0]::Bool[0] }

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

thread 'rustc' panicked at 'Box<Any>', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc_errors/lib.rs:416
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: build failed

Not on 1.15.

cc @mrjones
@brson brson added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2017
@arielb1 arielb1 self-assigned this Feb 16, 2017
@arielb1
Copy link
Contributor

arielb1 commented Feb 23, 2017

Fun note: another bug fixed on my shimmir branch. Not that I really want to merge it to 1.16/1.17.

@arielb1
Copy link
Contributor

arielb1 commented Feb 23, 2017 •
edited
Loading

Minified:

fn main() {
    &Some as &Fn(u32) -> _;
}

I think we should just have the first commit of shimmir to fix this.

@arielb1 arielb1 mentioned this issue Feb 23, 2017
Merged
arielb1 added a commit to arielb1/rust that referenced this issue Feb 23, 2017
@arielb1
trans: don't ICE when trying to create ADT trans-items
4e2c993 
ADTs are translated in-place from rustc_trans::callee, so no trans-items
are needed.

This fix will be superseded by the shimmir branch, but I prefer not to
backport that to beta.

Fixes rust-lang#39823.
@nikomatsakis
Copy link
Contributor

triage: P-high

@rust-highfive rust-highfive added the P-high High priority label Feb 23, 2017
eddyb added a commit to eddyb/rust that referenced this issue Feb 25, 2017
@eddyb
Rollup merge of rust-lang#40064 - arielb1:virtual-enum, r=nikomatsakis
f658ce4 
trans: don't ICE when trying to create ADT trans-items

ADTs are translated in-place from rustc_trans::callee, so no trans-items
are needed.

This fix will be superseded by the shimmir branch, but I prefer not to
backport that to beta.

Fixes rust-lang#39823.

Beta-nominating because regression.

r? @michaelwoerister
eddyb added a commit to eddyb/rust that referenced this issue Feb 25, 2017
@eddyb
Rollup merge of rust-lang#40064 - arielb1:virtual-enum, r=nikomatsakis
ecae5bf 
trans: don't ICE when trying to create ADT trans-items

ADTs are translated in-place from rustc_trans::callee, so no trans-items
are needed.

This fix will be superseded by the shimmir branch, but I prefer not to
backport that to beta.

Fixes rust-lang#39823.

Beta-nominating because regression.

r? @michaelwoerister
brson pushed a commit to brson/rust that referenced this issue Mar 9, 2017
@arielb1 @brson
trans: don't ICE when trying to create ADT trans-items
d735d95 
ADTs are translated in-place from rustc_trans::callee, so no trans-items
are needed.

This fix will be superseded by the shimmir branch, but I prefer not to
backport that to beta.

Fixes rust-lang#39823.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielb1 arielb1

Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trans: don't ICE when trying to create ADT trans-items arielb1/rust
4 participants
@brson @nikomatsakis @arielb1 @rust-highfive