Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.18 regression, rustasm6502 0.1.2, no rules expected token 'main' #41803

Closed
brson opened this issue May 7, 2017 · 4 comments
Closed

Rust 1.18 regression, rustasm6502 0.1.2, no rules expected token 'main' #41803

brson opened this issue May 7, 2017 · 4 comments
Assignees
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented May 7, 2017

https://github.com/jonas-schievink/rustasm6502

brian@ip-10-145-43-250:~/dev/rustasm6502⟫ git log -1
commit e2e2d558b251e728232273f8019f5a37eb2e112e
Author: Jonas Schievink <jonasschievink@gmail.com>
Date:   Wed Aug 10 23:04:27 2016 +0200

    Update my email
brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +beta -Vv
rustc 1.18.0-beta.1 (4dce67253 2017-04-25)
binary: rustc
commit-hash: 4dce67253d67785c74c8d270c38d774edd0deed8
commit-date: 2017-04-25
host: x86_64-unknown-linux-gnu
release: 1.18.0-beta.1
LLVM version: 3.9

brian@ip-10-145-43-250:~/dev/rustasm6502⟫ cargo +beta test
   Compiling rustasm6502 v0.1.1 (file:///mnt2/dev/rustasm6502)
error: no rules expected the token `main`
    --> src/lib.rs:1083:24
     |
1083 |     assert_eq!(my_map!(main), 0);
     |                --------^^^^- in this macro invocation

error: Could not compile `rustasm6502`.
Build failed, waiting for other jobs to finish...
error: build failed

cc @jonas-schievink @jseyfried

@brson brson added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label May 7, 2017
@brson brson changed the title Rust 1.18 regression, rustasm6502 0.1.2 Rust 1.18 regression, rustasm6502 0.1.2, no rules expected token 'main' May 7, 2017
@jonas-schievink
Copy link
Contributor

jonas-schievink commented May 7, 2017

I've turned on nightly Travis builds so I get notified when something breaks in the future. This crate seems like a good candidate for finding regressions in macros earlier.

@Mark-Simulacrum
Copy link
Member

Introduced by fe15119 -- #40597, cc @jseyfried

@jseyfried jseyfried self-assigned this May 8, 2017
@jseyfried jseyfried added P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2017
@nikomatsakis
Copy link
Contributor

@jseyfried -- any progress? should somebody else take a look?

@jseyfried
Copy link
Contributor

Fixed in #42005.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 16, 2017
Fix regression in `macro_rules!` name matching

Fixes rust-lang#41803.
r? @nrc
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 16, 2017
Fix regression in `macro_rules!` name matching

Fixes rust-lang#41803.
r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants