Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request: report the number of compilation errors #42793

Closed
hinaria opened this issue Jun 21, 2017 · 4 comments
Closed

request: report the number of compilation errors #42793

hinaria opened this issue Jun 21, 2017 · 4 comments
Assignees
@arielb1
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@hinaria
Copy link
Contributor

hinaria commented Jun 21, 2017 •
edited
Loading

No description provided.

@hinaria hinaria changed the title request: report the number of compile errors request: report the number of compilation errors Jun 21, 2017
@Mark-Simulacrum
Copy link
Member

Nominating for compiler team: we should make a decision here and stick to it, and I'm inclined to say that restoring the old functionality also leads to reports of incorrect numbering. If we can fix the numbering (easily) then I'm all for it though, but last I looked this wasn't an easy task.

@Mark-Simulacrum Mark-Simulacrum added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2017
@Ixrec
Copy link
Contributor

Ixrec commented Jun 21, 2017

If completely fixing the numbers is non-trivial, is it feasible/acceptable to report "There were at least 10 errors"? Or is the count so buggy we don't even know a minimum?

@Mark-Simulacrum
Copy link
Member

IIRC, I saw an issue recently about the returned value being 3 where it should've been 1, so I don't think that's true. It's possible that was due to old code though.

@nikomatsakis
Copy link
Contributor

triage: P-medium

My feeling is that if we can get a correct count, that would be good. This doesn't seem too hard in principle, but I guess there are... obstacles.

@rust-highfive rust-highfive added P-medium Medium priority and removed I-nominated labels Jun 29, 2017
@arielb1 arielb1 self-assigned this Jun 29, 2017
@arielb1 arielb1 mentioned this issue Jul 2, 2017
Merged
arielb1 added a commit to arielb1/rust that referenced this issue Jul 2, 2017
@arielb1
report the total number of errors on compilation failure
fb7ab9e 
Prior to this PR, when we aborted because a "critical pass" failed, we
displayed the number of errors from that critical pass. While that's the
number of errors that caused compilation to abort in *that place*,
that's not what people really want to know. Instead, always report the
total number of errors, and don't bother to track the number of errors
from the last pass that failed.

This changes the compiler driver API to handle errors more smoothly,
and therefore is a compiler-api-[breaking-change].

Fixes rust-lang#42793.
bors added a commit that referenced this issue Jul 2, 2017
@bors
Auto merge of #43015 - arielb1:every-error-counts, r=eddyb
2a99216 
report the total number of errors on compilation failure

Prior to this PR, when we aborted because a "critical pass" failed, we displayed the number of errors from that critical pass. While that's the number of errors that caused compilation to abort in *that place*, that's not what people really want to know. Instead, always report the total number of errors, and don't bother to track the number of errors from the last pass that failed.

This changes the compiler driver API to handle errors more smoothly, therefore is a compiler-api-[breaking-change].

Fixes #42793.

r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielb1 arielb1

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nikomatsakis @hinaria @arielb1 @Mark-Simulacrum @Ixrec @rust-highfive