Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bors: 422 Update is not a fast forward #43535

Open
Mark-Simulacrum opened this issue Jul 29, 2017 · 6 comments
Open

Bors: 422 Update is not a fast forward #43535

Mark-Simulacrum opened this issue Jul 29, 2017 · 6 comments
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Periodically we'll see bors not manage to push the built PR into master for some reason.

This is possibly because of submodules not being synchronized? Wild stab in the dark.
@Mark-Simulacrum Mark-Simulacrum added A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 29, 2017
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jul 29, 2017
Merged
@kennytm kennytm mentioned this issue Aug 5, 2017
Merged
@kennytm
Copy link
Member

kennytm commented Aug 5, 2017

cc servo/homu#24.

Could bors (homu) automatically wait for 5 seconds, and then push again in case of 422?

This was referenced Aug 7, 2017
Merged
Merged
@kennytm kennytm mentioned this issue Sep 26, 2017
Closed
@Eh2406
Copy link
Contributor

Eh2406 commented Sep 26, 2017

If we can track down where in the code this come from, I will try and add a retry.

@kennytm
Copy link
Member

kennytm commented Sep 26, 2017 •
edited
Loading

@Eh2406

https://github.com/servo/homu/blob/4424aedb08763c76e1ac682c96fea0adbd7232ff/homu/server.py#L518-L524

@Eh2406
Copy link
Contributor

Eh2406 commented Sep 26, 2017

Is the error that is being cout there thrown by github_set_ref? If so can we add a retry in github_set_ref, as it already has 422 special cases?

@Eh2406 Eh2406 mentioned this issue Sep 29, 2017
Merged
bors-servo pushed a commit to servo/homu that referenced this issue Oct 2, 2017
Auto merge of #134 - Eh2406:master, r=Manishearth
387c218 
retry if 422 Update is not a fast forward

As @kennytm suggested in rust-lang/rust#43535 This is a quick fix to try and suppress the [intermittent 422 errors.](#24)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/134)
<!-- Reviewable:end -->
@Eh2406
Copy link
Contributor

Eh2406 commented Apr 5, 2018

Move to close?

@ehuss ehuss mentioned this issue Oct 30, 2019
Open
@jonas-schievink
Copy link
Contributor

Triage: Still seems to be an issue according to rust-lang/homu#75

@petrochenkov petrochenkov mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kennytm @jonas-schievink @Eh2406 @Mark-Simulacrum