Tracking issue for clamp RFC #44095

Xaeroxe · 2017-08-26T05:28:34Z

Tracking issue for rust-lang/rfcs#1961

PR here: ~~#44097~~ #58710
Stabilization PR: #77872

TODO:

Have RFC pass final comment period
Implement RFC
Stabilize

Add clamp functions Implementation of clamp feature: Tracking issue: rust-lang#44095 RFC: rust-lang/rfcs#1961

…Rust library method of the same name. Fixes breakage from rust-lang/rust#44095.

@Manishearth

Explicitly invoke `Au::clamp()` to avoid colliding with the unstable Rust library method of the same name. Fixes breakage from rust-lang/rust#44095. r? @Manishearth

aturon · 2017-09-08T20:05:56Z

cc @rust-lang/libs, this is a case similar to min/max, where the ecosystem was already using the clamp name, and hence adding it has caused ambiguity. This is permitted breakage per semver policy, but it's nevertheless causing downstream pain.

Nominating for the triage meeting on Tues.

Any thoughts in the meantime?

BurntSushi · 2017-09-08T20:56:46Z

I'm kind of with @bluss on this one in that it would be nice not to repeat it. "Clamp" is probably a great name, but could we sidestep this by choosing a different name?

Xaeroxe · 2017-09-08T21:05:39Z

restrict
clamp_to_range
min_max (Because it's kind of like combining min and max.)
These might work. Can we use crater to determine how bad the impact of clamp actually is? clamp is well recognized across several languages and libraries.

aturon · 2017-09-08T21:28:51Z

If we think we might need to rename, it's probably best to revert the PR immediately, and then test more carefully with crater etc. @Xaeroxe, up for that?

Xaeroxe · 2017-09-08T21:34:51Z

Sure. I've never used crater before, but I can learn.

aturon · 2017-09-08T21:39:13Z

@Xaeroxe ah sorry, I meant getting a revert PR up quickly. (I'm on vacation today so you may need someone else on libs, like @BurntSushi or @alexcrichton, to help land it).

Xaeroxe · 2017-09-08T21:43:37Z

I'm preparing the PR now. Have fun on your vacation!

Xaeroxe · 2017-09-08T22:14:34Z

PR ready #44438

Revert clamp Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.

egilburg · 2017-09-09T23:19:18Z

Could clamp_to_range(min, max) be composed of clamp_to_min(min) and clamp_to_max(max) (with the additional assertion that min <= max), but those functions could also be called independently?

Xaeroxe · 2017-09-09T23:21:56Z

I suppose that idea mandates an RFC.

Xaeroxe · 2017-09-09T23:29:21Z

I gotta say though I've been working on getting a 4 line function into the std library for 6 months now. I'm kind of worn out. The same function got merged into num in 2 days and that's good enough for me. If anyone else really wants this in the std library go ahead, but I'm just not ready for another 6 months of this.

Xaeroxe · 2017-09-11T15:54:25Z

I'm reopening this so that @aturon 's previous nomination will still be seen.

scottmcm · 2017-09-11T16:30:41Z

I think that either this should go in as-written or the guidance on what changes can be made should be updated to avoid wasting peoples' time in future.

It was very clear from early that this could cause the breakage it did. Personally, I compared it to ord_max_min which broke a bunch of things:

Add max and min to Ord #42496
Multiple max found petgraph/petgraph#153
glm-0.2.3 beta regression #43667
as_num-0.2.2 beta regression #43657
direct-0.1.0 beta regression #43665
tree-0.4.1 beta regression #43682
statrs 0.6.0 and 0.7.0 beta regression #43680
Conflicting methods min and max on Set and Map apasel422/tree#23
Fix breakage with Order.min and Order.max on nightly dche/glm-rs#21
(probably more, but those were linked to the tracking issue)

And the response to that was "The function Ord::min was added [...] The libs team decided today that this is accepted breakage". And that was a TMTOWTDI feature with a more-common name, whereas clamp didn't already exist in std under a different form.

It feels, subjectively, to me that if this RFC is reverted, the actual rule is "You basically can't put new methods on traits in std, except maybe Iterator".

CryZe · 2017-09-11T16:42:58Z

You also can't really put new methods on actual types either. Consider the situation where someone had an "extension trait" for a type in std. Now std implements a method the extension trait provided as an actual method on this type. Then this reaches stable, but this new method is still behind a feature flag. The compiler will then complain that the method is behind a feature flag and can't be used with the stable toolchain, instead of the compiler choosing the extension trait's method like before and thus causing breakage on the stable compiler.

Xaeroxe · 2017-09-11T16:46:00Z

It's also worth noting: This isn't just a standard library problem. Method call syntax makes it really difficult to avoid introducing breaking changes just about anywhere in the ecosystem.

Xaeroxe · 2020-09-09T19:37:37Z

This has been merged and unstable for about a year and a half now. How do we feel about stabilizing this?

EdorianDark · 2020-09-13T09:53:45Z

I would love stabilizing this!

KamilaBorowska · 2020-09-18T10:23:07Z

If clamp method name conflict sounds like an issue, I suggested changing name resolution at one point in #66852 (comment), and it would help with this too.

matklad · 2020-10-11T14:29:39Z

@Xaeroxe I think the process is to submit stabilization PR and ask for libs team consensus on that. It seems that t-libs is overloaded and can't keep up with non-fcped things.

Xaeroxe · 2020-10-12T21:26:20Z

Okay, did that #77872

kennytm · 2020-10-16T05:36:19Z

@matklad actually an FCP proposal already started last year at #44095 (comment), but it is stuck because there is one remaining checkbox.

Xaeroxe · 2020-10-16T15:31:48Z

In that case, I think being pinged about once a year on an issue is pretty tolerable.

@Kimundi
@sfackler
@withoutboats

#44095 (comment) is still awaiting your attention

LukasKalbertodt · 2020-10-26T21:57:05Z

The libs team has changed quite a bit since the FCP was started. What do you all think about just starting a new FCP in the stabilization PR? Feels like that shouldn't take longer than waiting for the remaining checkboxes here.

Xaeroxe · 2020-10-29T15:06:27Z

@LukasKalbertodt fine by me, do you mind kicking that off?

m-ou-se · 2020-11-11T15:55:26Z

Cancelling the FCP here, because that FCP now happened on the stabilization PR: #77872 (comment)

@Fcpbot cancel

m-ou-se · 2020-11-11T15:55:53Z

uh

@rfcbot cancel

rfcbot · 2020-11-11T15:55:54Z

@m-ou-se proposal cancelled.

Stabilize clamp Tracking issue: rust-lang#44095 Clamp has been merged and unstable for about a year and a half now. How do we feel about stabilizing this?

jplatte · 2020-11-23T12:58:49Z

Stabilized in #77872, I think this can be closed.

Move {f32,f64}::clamp to core. `clamp` was recently stabilized (tracking issue: rust-lang#44095). But although `Ord::clamp` was added in `core` (because `Ord` is in `core`), the versions for the `f32` and `f64` primitives were added in `std` (together with `floor`, `sin`, etc.), not in `core` (together with `min`, `max`, `from_bits`, etc.). This change moves them to `core`, such that `clamp` on floats is available in `no_std` programs as well.

Rust std's `clamp` has been stabilised in 1.50: rust-lang/rust#44095 This is already the minimum supported version, so no change there 👍

This was referenced Aug 26, 2017

Add clamp functions #44097

Merged

Add clamp RFC rust-lang/rfcs#1961

Merged

Mark-Simulacrum added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 26, 2017

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 6, 2017

Rollup merge of rust-lang#44097 - Xaeroxe:clamp, r=burntsushi

98b1d8c

Add clamp functions Implementation of clamp feature: Tracking issue: rust-lang#44095 RFC: rust-lang/rfcs#1961

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 7, 2017

Rollup merge of rust-lang#44097 - Xaeroxe:clamp, r=burntsushi

44351ed

Add clamp functions Implementation of clamp feature: Tracking issue: rust-lang#44095 RFC: rust-lang/rfcs#1961

pcwalton added a commit to pcwalton/app_units that referenced this issue Sep 8, 2017

Explicitly invoke Au::clamp() to avoid colliding with the unstable …

7136c16

…Rust library method of the same name. Fixes breakage from rust-lang/rust#44095.

pcwalton mentioned this issue Sep 8, 2017

Explicitly invoke Au::clamp() to avoid colliding with the unstable Rust library method of the same name. servo/app_units#37

Merged

This comment has been minimized.

Sign in to view

aturon added the I-nominated label Sep 8, 2017

Xaeroxe mentioned this issue Sep 8, 2017

Revert clamp #44438

Merged

bors added a commit that referenced this issue Sep 9, 2017

Auto merge of #44438 - Xaeroxe:clamp, r=Mark-Simulacrum

929b878

Revert clamp Revert clamp per #44095 (comment) while we take time to assess the potential backwards compatibility damage done by it.

Xaeroxe closed this as completed Sep 9, 2017

Xaeroxe reopened this Sep 11, 2017

Xaeroxe mentioned this issue Oct 12, 2020

Stabilize clamp #77872

Merged

m-ou-se closed this as completed Nov 23, 2020

m-ou-se mentioned this issue Nov 27, 2020

Move {f32,f64}::clamp to core. #79473

Merged

vicky5124 mentioned this issue Dec 6, 2020

Updating Dependencies silvia-odwyer/photon#56

Closed

parity-benchapp bot mentioned this issue Mar 10, 2021

Initial integration of Gilts pallet (Kusama) paritytech/polkadot#2587

Merged

mockersf mentioned this issue Mar 13, 2021

[Merged by Bors] - use std clamp instead of Bevy's bevyengine/bevy#1644

Closed

bors bot pushed a commit to bevyengine/bevy that referenced this issue Mar 13, 2021

use std clamp instead of Bevy's (#1644)

75ae20d

Rust std's `clamp` has been stabilised in 1.50: rust-lang/rust#44095 This is already the minimum supported version, so no change there 👍

TheHunterDog mentioned this issue Mar 26, 2021

Rust compile error's luliic2/rttnw#1

Closed

afalout mentioned this issue Apr 24, 2021

[WiP] aoide - External music library mixxxdj/mixxx#2282

Closed

1 task

m-ou-se mentioned this issue Jun 19, 2021

Use RangeInclusive for fNN::lerp #86462

Closed

LetsMelon mentioned this issue Jul 7, 2022

fix rust/44095 (f64::clamp) todos linebender/resvg#522

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for clamp RFC #44095

Tracking issue for clamp RFC #44095

Xaeroxe commented Aug 26, 2017 •

edited

Loading

This comment has been minimized.

aturon commented Sep 8, 2017

BurntSushi commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

aturon commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

aturon commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

egilburg commented Sep 9, 2017 •

edited

Loading

Xaeroxe commented Sep 9, 2017

Xaeroxe commented Sep 9, 2017

Xaeroxe commented Sep 11, 2017

scottmcm commented Sep 11, 2017

CryZe commented Sep 11, 2017 •

edited

Loading

Xaeroxe commented Sep 11, 2017

Xaeroxe commented Sep 9, 2020

EdorianDark commented Sep 13, 2020

KamilaBorowska commented Sep 18, 2020 •

edited

Loading

matklad commented Oct 11, 2020

Xaeroxe commented Oct 12, 2020

kennytm commented Oct 16, 2020

Xaeroxe commented Oct 16, 2020

LukasKalbertodt commented Oct 26, 2020

Xaeroxe commented Oct 29, 2020

m-ou-se commented Nov 11, 2020

m-ou-se commented Nov 11, 2020

rfcbot commented Nov 11, 2020

jplatte commented Nov 23, 2020

Tracking issue for clamp RFC #44095

Tracking issue for clamp RFC #44095

Comments

Xaeroxe commented Aug 26, 2017 • edited Loading

This comment has been minimized.

aturon commented Sep 8, 2017

BurntSushi commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

aturon commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

aturon commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

Xaeroxe commented Sep 8, 2017

egilburg commented Sep 9, 2017 • edited Loading

Xaeroxe commented Sep 9, 2017

Xaeroxe commented Sep 9, 2017

Xaeroxe commented Sep 11, 2017

scottmcm commented Sep 11, 2017

CryZe commented Sep 11, 2017 • edited Loading

Xaeroxe commented Sep 11, 2017

Xaeroxe commented Sep 9, 2020

EdorianDark commented Sep 13, 2020

KamilaBorowska commented Sep 18, 2020 • edited Loading

matklad commented Oct 11, 2020

Xaeroxe commented Oct 12, 2020

kennytm commented Oct 16, 2020

Xaeroxe commented Oct 16, 2020

LukasKalbertodt commented Oct 26, 2020

Xaeroxe commented Oct 29, 2020

m-ou-se commented Nov 11, 2020

m-ou-se commented Nov 11, 2020

rfcbot commented Nov 11, 2020

jplatte commented Nov 23, 2020

Xaeroxe commented Aug 26, 2017 •

edited

Loading

egilburg commented Sep 9, 2017 •

edited

Loading

CryZe commented Sep 11, 2017 •

edited

Loading

KamilaBorowska commented Sep 18, 2020 •

edited

Loading