-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-module TLS imports are broken on MIPS #45654
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Comments
alexcrichton
added
the
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
label
Oct 31, 2017
11 tasks
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Oct 31, 2017
Discovered in rust-lang#45529 it looks like cross-module TLS imports aren't quite working today, especially with `hidden` visibility which mostly comes up with multiple codegen units. As a result this completely disables compiling with ThinLTO and multiple codegen units on MIPS when bootstrapping. cc rust-lang#45654, the tracking issue for this
bors
added a commit
that referenced
this issue
Oct 31, 2017
rustbuild: Don't build with ThinLTO on MIPS Discovered in #45529 it looks like cross-module TLS imports aren't quite working today, especially with `hidden` visibility which mostly comes up with multiple codegen units. As a result this completely disables compiling with ThinLTO and multiple codegen units on MIPS when bootstrapping. cc #45654, the tracking issue for this
A fix has landed upstream, I'm now testing to see whether it works. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Nov 6, 2017
Now that the upstream LLVM bug is now fixed this commit cherry-picks the commit onto our LLVM and then re-enables the ThinLTO paths for MIPS. Closes rust-lang#45654
bors
added a commit
that referenced
this issue
Nov 11, 2017
…erister rustbuild: Re-enable ThinLTO for MIPS Now that the upstream LLVM bug is now fixed this commit cherry-picks the commit onto our LLVM and then re-enables the ThinLTO paths for MIPS. Closes #45654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
This is a tracking issue for this debugging story which concludes with:
Notably the import of
foo
on MIPS is not flagged as "TLS" under the "Type" column when the import is bothhidden
visibility and compiled with-relocation-model=pic
. This is most likely an LLVM bug but we're starting to implement workarounds for this, and those workarounds will reference this issue.The text was updated successfully, but these errors were encountered: