-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decl_macro and use std::vec combo breaks rustdoc #47038
Comments
10 tasks
bors
added a commit
that referenced
this issue
Jan 1, 2018
Add compiler docs testing to CI. Fixes #47025. I don't know if `x86_64-gnu` is the right builder for this, but there seems to be time left on [Travis](https://travis-ci.org/rust-lang/rust/jobs/307488864). Remaining problems blocking this PR: - [x] broken links caused by rustdoc issues: - [x] `pub use self::Enum::...`: #46766 and #46767 (fixed by #47050, thanks @ollie27!) - [x] `impl Deref for DerefToStdType`: #32129 (ignored in linkchecker) - [x] `#[feature(decl_macro)]` and `use std::vec`: #47038 (ignored in linkchecker) - [x] `rustc_data_structures::sync::{Lrc, RwLock}` aliases `std` types: #32130 (ignored in linkchecker) - [x] markdown differences, in rust repository and in external crates, now failing the build with #46880 merged (all fixed) - [x] multiple crate updates needed: `rand`, `log`, `parking_lot_core`, `flate2` - [x] submodule updates needed to deduplicate dependencies: `rust-installer`, ~`cargo`~ (done by #47052) - [x] #44953 test broken by `log` update (removed, this can be controversial) - [x] Waiting `x86_64-gnu` build results ([done](https://travis-ci.org/rust-lang/rust/builds/323451069)) See individual commits for more details.
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jan 8, 2018
…t, r=GuillaumeGomez rustdoc: Don't import macros from private imports Fixes rust-lang#47038
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A crate with the following reduced
lib.rs
breaks rustdoc:Indeed, rustdoc links to
vec!()
docs in index.html because this macro has the same name than the imported module (???).Furthermore, the macro page linked has broken links because it is copied in the crate namespace, instead of being directly https://doc.rust-lang.org/std/vec/struct.Vec.html.
The text was updated successfully, but these errors were encountered: