Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression from seemingly harmless changeset #47154

Closed
michaelwoerister opened this issue Jan 3, 2018 · 4 comments
Closed

Performance regression from seemingly harmless changeset #47154

michaelwoerister opened this issue Jan 3, 2018 · 4 comments
Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

#46278 seems to have caused a noticeable performance regression:
http://perf.rust-lang.org/compare.html?start=d5f2745e7ccd247da50f0cb18318ac477e5bccbf&end=5deba220d4c42b5313d7e71731ce5e8698866684&stat=wall-time

It updates a few dependencies (e.g. flate2). Maybe they've become slower?

Anybody know what else this could be about, @rust-lang/compiler?
@michaelwoerister michaelwoerister added the I-compiletime Issue: Problems and improvements with respect to compile times. label Jan 3, 2018
@alexcrichton
Copy link
Member

My money would be on the update to log, it may be the case that 0.3.9 is slower than 0.4.0 because of the shims it introduces (just a hypothesis though). It should be very easy to convert to 0.4.0 though, just bumping cargo.toml requirements throughout the compiler

@MaloJaffre
Copy link
Contributor

I am currently trying to fix this regression.

This was referenced Jan 3, 2018
Merged
Merged
bors added a commit to rust-lang/cargo that referenced this issue Jan 3, 2018
@bors
Auto merge of #4891 - MaloJaffre:compiler-docs-regression, r=alexcric…
28f89fd 
…hton

Try to fix a perf regression by updating log

Upgrade `log` to `0.4` in `cargo` and `cargotest`.

Cc: rust-lang/rust#47154.
@kennytm kennytm mentioned this issue Jan 7, 2018
Closed
bors added a commit that referenced this issue Jan 7, 2018
@bors
Auto merge of #47161 - MaloJaffre:compiler-docs-regression, r=alexcri…
ee220da 
…chton

Try to fix a perf regression by updating log

Upgrade `log` to `0.4` in multiple crates ~and `cargo`~.
Cc: #47154.
@kennytm kennytm added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Jan 9, 2018
@andjo403
Copy link
Contributor

andjo403 commented Mar 6, 2018

was this not fixed with #47161 and #4891 so this can be closed now?

@michaelwoerister
Copy link
Member Author

Yes, it was. Thanks for the hint, @andjo403!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @kennytm @andjo403 @michaelwoerister @MaloJaffre