Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: private::weak_task::weaken_task: Take a closure that takes a PortOne instead of a Port #4729

Closed
catamorphism opened this issue Feb 1, 2013 · 3 comments
Closed

core: private::weak_task::weaken_task: Take a closure that takes a PortOne instead of a Port #4729

catamorphism opened this issue Feb 1, 2013 · 3 comments
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

Comment says "I've experienced bugginess with oneshot pipes and try_send." If so, the bugs should be filed.
@bstrie
Copy link
Contributor

bstrie commented Jun 25, 2013

The only users of weaken_task are the test cases and the old libuv support. It's possible that this function is obsoleted by the new runtime work.

@brson
Copy link
Contributor

brson commented Jun 27, 2013

I do hope to remove this feature after we remove the old uv code.

@brson
Copy link
Contributor

brson commented Aug 1, 2013

weak_task is dead.

@brson brson closed this as completed Aug 1, 2013
@varkor varkor mentioned this issue Jul 8, 2018
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 28, 2020
@bors
Auto merge of rust-lang#5912 - ebroto:needless_doctest_main_improveme…
f8db258 
…nts, r=Manishearth,flip1995

Parse doctests in needless_doctest_main

This switches from text-based search to running the parser to avoid false positives. Inspired by how [rustdoc](https://github.com/rust-lang/rust/blob/3f3250500fe152b5759c21453ba9a9129808d0d8/src/librustdoc/test.rs#L366) handles this and by rust-lang#4729.

cc @llogiq

changelog: Fix multiple false positives in [`needless_doctest_main`].

Fixes rust-lang#5879
Fixes rust-lang#4906
Fixes rust-lang#5103
Fixes rust-lang#4698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @catamorphism @bstrie