Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit set of bundled MinGW import libraries #47359

Open
retep998 opened this issue Jan 11, 2018 · 1 comment
Open

Audit set of bundled MinGW import libraries #47359

retep998 opened this issue Jan 11, 2018 · 1 comment
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows-gnu Toolchain: GNU, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@retep998
Copy link
Member

retep998 commented Jan 11, 2018 •
edited
Loading

The set of import libraries that Rust bundles should strictly be what is needed to link against the libraries that come with the Rust distribution. Missing an import library causes link errors while including unnecessary import libraries bloats the distribution.

Library Necessary
libadvapi32.a Yes
libbcrypt.a No
libcomctl32.a No
libcomdlg32.a No
libcredui.a Yes and missing!
libcrypt32.a No
libdbghelp.a Yes
libgdi32.a Yes
libimagehlp.a No
libiphlpapi.a No
libkernel32.a Yes
libmsimg32.a Yes
libmsvcrt.a Yes
libodbc32.a No
libole32.a No
liboleaut32.a No
libopengl32.a Yes
libpsapi.a Yes
librpcrt4.a No
libsecur32.a Yes and missing!
libsetupapi.a Yes
libshell32.a Yes
libuser32.a Yes
libuserenv.a Yes
libuuid.a No
libwinhttp.a No
libwinmm.a No
libwinspool.a Yes
libws2_32.a Yes
libwsock32.a No
@retep998 retep998 added A-linkage Area: linking into static, shared libraries and binaries O-windows-gnu Toolchain: GNU, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 11, 2018
cuviper added a commit to cuviper/rayon that referenced this issue Jan 11, 2018
@cuviper
avoid compiletest_rs on windows-gnu, rust-lang/rust#47359
dc8b988
@alexcrichton alexcrichton mentioned this issue Jan 16, 2018
Merged
@retep998 retep998 mentioned this issue Mar 15, 2018
Closed
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 23, 2018
@mati865 mati865 mentioned this issue Nov 9, 2018
Closed
@ChrisDenton ChrisDenton mentioned this issue Mar 4, 2023
Merged
@Enselic
Copy link
Member

Enselic commented Oct 6, 2023

Triage: The above list looks outdated according to #108262 (comment). Not sure if we should keep this issue open, but it is kind of a neat list that is useful to base an updated list on, so I'll leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows-gnu Toolchain: GNU, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Enselic @retep998 @XAMPPRocky