Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency tracking README outdated? #47935

Closed
mark-i-m opened this issue Feb 1, 2018 · 4 comments
Closed

Dependency tracking README outdated? #47935

mark-i-m opened this issue Feb 1, 2018 · 4 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@mark-i-m
Copy link
Member

mark-i-m commented Feb 1, 2018

I believe that https://rust-lang-nursery.github.io/rustc-guide/query.html is more updated than https://github.com/rust-lang/rust/blob/master/src/librustc/dep_graph/README.md

Is there anything in the latter that is missing in the former?

cc @michaelwoerister @nikomatsakis
@gsollazzo gsollazzo added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Feb 1, 2018
@nikomatsakis
Copy link
Contributor

I plan to do a sweep soon and remove the READMEs from the repo. I'm not sure how much of the material in that particular one is still relevant though.

@jkordish jkordish added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Feb 7, 2018
@Manishearth Manishearth removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 8, 2018
@mark-i-m mark-i-m mentioned this issue Feb 23, 2018
Closed
10 tasks
@nikomatsakis nikomatsakis mentioned this issue Feb 25, 2018
Closed
19 tasks
@mark-i-m
Copy link
Member Author

@michaelwoerister This is one of the last READMEs. Any thoughts on what might still need to be moved?

@michaelwoerister
Copy link
Member

The readme is largely outdated. The "Testing the dependency graph" and "Debugging the dependency graph" sections are still correct, I think, but the rest is probably just confusing at this point.

@nikomatsakis nikomatsakis mentioned this issue Mar 13, 2018
Open
@nikomatsakis
Copy link
Contributor

I opened rust-lang/rustc-dev-guide#87 to talk about moving that bit of content over.

@mark-i-m mark-i-m mentioned this issue Mar 16, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 19, 2018
@kennytm
Rollup merge of rust-lang#49092 - mark-i-m:deptrack_readme, r=nikomat…
7bc9fe3 
…sakis

Replace many of the last references to readmes

In particular, this removes the dep track readme, so it should not be merged before rust-lang/rustc-dev-guide#92

Fix rust-lang#47935

cc rust-lang#48478

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jkordish @nikomatsakis @Manishearth @michaelwoerister @mark-i-m @gsollazzo