Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md should not recommend opening issues for feature requests in the RFC repo. #48393

Closed
ordovicia opened this issue Feb 21, 2018 · 2 comments
Closed

CONTRIBUTING.md should not recommend opening issues for feature requests in the RFC repo. #48393

ordovicia opened this issue Feb 21, 2018 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@ordovicia
Copy link
Contributor

CONTRIBUTING.md currently recommends opening issues for feature requests in the RFC repo.

Feature Requests

To request a change to the way that the Rust language works, please open an issue in the RFCs repository rather than this one. New features and other significant language changes must go through the RFC process.

But feature requests should be discussed in the internal forum, not in the issue tracker of the RFC repo.
So the CONTRIBUTING.md should be amended to guide contributors properly.
@pietroalbini pietroalbini added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Feb 27, 2018
@klnusbaum
Copy link
Contributor

I'll take a stab at this.

@klnusbaum klnusbaum mentioned this issue Mar 3, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 12, 2018
@kennytm
Rollup merge of rust-lang#48705 - klnusbaum:update_rfc_process, r=aturon
7bd8f6e 
Update Feature Request instructions

As noted in rust-lang#48393 the contribution instructions for submitting a Feature Request are a little hasty, suggesting that the user immediately create an issue in the RFC repository. For users that want to submit a feature request, let's instead point them directly to the README file for the RFC repository, which contains detailed instructions on how to submit a Feature Request.
@Baelyk
Copy link

Baelyk commented Mar 17, 2018

Hey @aturon, I noticed that you were the one who approved the PR so I thought I should mention you rather than just commenting (hope thats okay), but shouldn't this issue now be closed?

@aturon aturon closed this as completed Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@klnusbaum @aturon @pietroalbini @ordovicia @Baelyk