Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-traits implementations shouldn't appear if empty #48882

Closed
GuillaumeGomez opened this issue Mar 9, 2018 · 4 comments
Closed

Auto-traits implementations shouldn't appear if empty #48882

GuillaumeGomez opened this issue Mar 9, 2018 · 4 comments
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

https://doc.rust-lang.org/nightly/std/env/struct.Args.html
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 9, 2018
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 9, 2018
@kennytm kennytm added the C-bug Category: This is a bug. label Mar 9, 2018
@clarfonthey
Copy link
Contributor

I'd argue that !Send and !Sync should show up in the auto traits section.

@GuillaumeGomez
Copy link
Member Author

Hum no. It's a "manual" binding.

@clarfonthey
Copy link
Contributor

It depends on if you see it as "auto trait" implementations or auto "trait implementations"

@GuillaumeGomez
Copy link
Member Author

There is nothing automatic in here so I don't see where the debate is. :-/

@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 9, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 12, 2018
@kennytm
Rollup merge of rust-lang#48898 - GuillaumeGomez:remove-empty-section…
e30d89d 
…, r=QuietMisdreavus

Remove auto trait implementation section when empty

Fixes rust-lang#48882.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennytm @GuillaumeGomez @clarfonthey