Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for codegen_llvm to d.r-l.o/nightly/nightly-rustc #51737

Closed
bjorn3 opened this issue Jun 23, 2018 · 4 comments
Closed

Add docs for codegen_llvm to d.r-l.o/nightly/nightly-rustc #51737

bjorn3 opened this issue Jun 23, 2018 · 4 comments
Assignees
@davidtwco
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jun 23, 2018

No description provided.

@stokhos stokhos added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-codegen Area: Code generation A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Jun 23, 2018
@jkordish jkordish added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 26, 2018
@scottmcm
Copy link
Member

👍 -- I just wanted to link to Builder::nuwadd and friends, and couldn't.

@scottmcm scottmcm mentioned this issue Jul 10, 2018
Closed
@QuietMisdreavus
Copy link
Member

@Mark-Simulacrum @kennytm I'm not sure what needs to happen to get this included in the compiler docs that get posted there, but it seems like this is a bit of an oversight there?

@QuietMisdreavus QuietMisdreavus added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-codegen Area: Code generation labels Aug 23, 2018
@kennytm
Copy link
Member

kennytm commented Aug 24, 2018

You just need to change this line I think. Codegen is a dynamic library outside of the rustc driver executable, and thus not included when checking the dependency of the rustc-driver crate alone.

rust/src/bootstrap/doc.rs

Line 715 in 63d6649

for root_crate in &["rustc", "rustc_driver"] {

cc @davidtwco #49193.

@Mark-Simulacrum
Copy link
Member

Yes, that looks accurate. Should be a relatively simple fix...

@davidtwco davidtwco self-assigned this Aug 24, 2018
@davidtwco davidtwco mentioned this issue Aug 24, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Aug 24, 2018
@kennytm
Rollup merge of rust-lang#53666 - davidtwco:issue-51737, r=Mark-Simul…
c6039de 
…acrum

Added rustc_codegen_llvm to compiler documentation.

Fixes rust-lang#51737.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidtwco davidtwco

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jkordish @kennytm @davidtwco @Mark-Simulacrum @QuietMisdreavus @bjorn3 @scottmcm @stokhos