Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run compiler unit tests without stage 1 build #51748

Closed
cramertj opened this issue Jun 23, 2018 · 1 comment · Fixed by #95445
Closed

Run compiler unit tests without stage 1 build #51748

cramertj opened this issue Jun 23, 2018 · 1 comment · Fixed by #95445
Assignees
@Mark-Simulacrum
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@cramertj
Copy link
Member

./x.py test src/libsyntax --stage 0 builds all the way through a stage 1 build before actually running the tests, so any changes to libsyntax require rebuilding all of rustc in order to rerun the unit tests. This is a really slow process, making it much harder to write and run unit tests for rustc code.
@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 24, 2018
@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Oct 19, 2019
@jyn514 jyn514 added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Jan 1, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 30, 2021

I think this is a duplicate of #44293.

@jyn514 jyn514 mentioned this issue Mar 29, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Mar 31, 2022
@Dylan-DPC
Rollup merge of rust-lang#95445 - jyn514:rustc-unit-tests, r=Dylan-DPC
14d8bfd 
Don't build the full compiler before running unit tests

This has been present since `builder.ensure` was first added in rust-lang#43059.
It's unclear to me why it was added then - I tested these changes locally
with `x test compiler/rustc_data_structures --stage 0` and they worked fine.

Fixes rust-lang#51748.
@bors bors closed this as completed in ae12597 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't build the full compiler before running unit tests jyn514/rust
4 participants
@Mark-Simulacrum @cramertj @jyn514 @JohnTitor