Improve "self" errors a bit #54369
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-help-wanted
Call for participation: Help is requested to fix this issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Comments
GuillaumeGomez
added
the
A-diagnostics
|
Label emitted in the following two places rust/src/librustc_resolve/lib.rs Lines 3024 to 3025 in 3bc2ca7 The easiest change is rewording as proposed. A harder change would be to make it context dependent and figure out wether it is in happening in a |
estebank
added
E-easy
|
Hi, I took an easy path and implemented #54495. If you dislike this approach I can redo this, but It feels to me that taking context in account complicates things, plus I'm not sure about wording. |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this issue
Dec 11, 2018
Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Dec 12, 2018
Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this issue
Dec 12, 2018
Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Dec 14, 2018
Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
bors
added a commit
that referenced
this issue
Dec 14, 2018
Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request #54495 referencing issue #54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently it looks like this:
Rewording a bit like "
selfvalue is a keyword only available in methods withselfparameter" would read a bit better and would be more explicit.The text was updated successfully, but these errors were encountered: