Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo warning during x.py build: "the cargo feature edition is now stable" #54697

Closed
RalfJung opened this issue Sep 30, 2018 · 4 comments · Fixed by #54916
Closed

Cargo warning during x.py build: "the cargo feature edition is now stable" #54697

RalfJung opened this issue Sep 30, 2018 · 4 comments · Fixed by #54916

Comments

@RalfJung
Copy link
Member

Plenty of lines like the following are printed during a build:

warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest

This is likely caused by these:

src/tools/rls/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/rustc_tools_util/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/clippy_lints/Cargo.toml
1:cargo-features = ["edition"]

src/tools/clippy/clippy_dev/Cargo.toml
1:cargo-features = ["edition"]
@matthiaskrgr
Copy link
Member

The clippy ones are already fixed upstream: rust-lang/rust-clippy#3242

@cuviper
Copy link
Member

cuviper commented Oct 1, 2018

ISTR that 1.30-beta was only preview-stabilizing edition stuff, but that they'll be unstable in the 1.30 release. So when the current master branch forks off as 1.31-beta, it will still need to bootstrap with that 1.30 stable.

But if cargo is going to keep edition stable in 1.30, then we can go ahead and nuke those.

@RalfJung
Copy link
Member Author

RalfJung commented Oct 8, 2018

The clippy fix has landed in rustc. RLS also has a fix at rust-lang/rls#1074. What would it take to get that into rustc?

@matthiaskrgr
Copy link
Member

Needs submodule update, I can do that this afternoon

@matthiaskrgr matthiaskrgr mentioned this issue Oct 8, 2018
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 11, 2018
@matthiaskrgr
submodules: update rls from 15d4d4a to 440a985
55553bb 
Changes:

Apply Clippy lints
Respect build_dir when creating external build plans
Fix Windows tests
Implement external build plan
Detect manifest diagnostic position for toml::de::Error
Fix std::sync hover doc expectation
Apply CI specific long timeout
Propagate cargo errors as manifest diagnostics
Add test for use statement function completions
Refactor cmd test `within_timeout`
Avoid stdout-writer/rls process exit race
Improve cmd test "no shutdown response" error message
Add RUST_BACKTRACE=1 to ci env
Improve cmd test timeout reliability
Fix use statement function suggestions
Revert "Revert "Remove "edition" Cargo feature (it's stable now)""
Add build_wait() tests
Automatically tune wait_to_build
Rework cmd tests

Fixes rust-lang#54697
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Oct 11, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#54916 - matthiaskrgr:submodules_update, r=o…
8ce7ce2 
…li-obk

submodules: update clippy, rls and cargo, fix toolstate

rustfmt update failed because of different rustc-ap-syntax versions.

fix clippy toolstate failure

Fixes rust-lang#54697
bors added a commit that referenced this issue Oct 11, 2018
@bors
Auto merge of #54916 - matthiaskrgr:submodules_update, r=oli-obk
8e9aa14 
submodules: update clippy, rls and cargo, fix toolstate

rustfmt update failed because of different rustc-ap-syntax versions.

fix clippy toolstate failure

Fixes #54697
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 13, 2018
@matthiaskrgr
submodules: update rls from 15d4d4a to 440a985
2e84e9c 
Changes:

Apply Clippy lints
Respect build_dir when creating external build plans
Fix Windows tests
Implement external build plan
Detect manifest diagnostic position for toml::de::Error
Fix std::sync hover doc expectation
Apply CI specific long timeout
Propagate cargo errors as manifest diagnostics
Add test for use statement function completions
Refactor cmd test `within_timeout`
Avoid stdout-writer/rls process exit race
Improve cmd test "no shutdown response" error message
Add RUST_BACKTRACE=1 to ci env
Improve cmd test timeout reliability
Fix use statement function suggestions
Revert "Revert "Remove "edition" Cargo feature (it's stable now)""
Add build_wait() tests
Automatically tune wait_to_build
Rework cmd tests

Fixes rust-lang#54697
bors added a commit that referenced this issue Oct 13, 2018
@bors
Auto merge of #54916 - matthiaskrgr:submodules_update, r=oli-obk
4699283 
submodules: update clippy, rls and cargo, fix toolstate

rustfmt update failed because of different rustc-ap-syntax versions.

fix clippy toolstate failure

Fixes #54697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy, rls and cargo, fix toolstate matthiaskrgr/rust
3 participants
@cuviper @RalfJung @matthiaskrgr