-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to make sure the output of "rustc --expand pretty" can compile #5580
Comments
To clarify: if I understand you correctly, you're saying that the expansion of error!("...") was being rendered by pprust as log(1,"..."), not that the expansion was actually incorrect. Is that correct? First off, that would obviously be a bug in the pretty-printer, which should be fixed. The larger issue of making sure that pretty-printed code compiles I would nominate for well-covered. |
@jbclements: Yep, that was the problem, it's fixed now though. The larger issue still stands. |
just a bug, removing milestone/nomination. |
Fixed by #14106! |
Yay! |
deps: remove unused regex dependency from root crate changelog: none
I ran into an issue in #5578 where
error!("...")
was getting expanded intolog(1, "...")
instead of__log(1, "...")
, which resulted in a compile error. We should add some tests that make sure we can still compile code after macros have been expanded.The text was updated successfully, but these errors were encountered: