Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to make sure the output of "rustc --expand pretty" can compile #5580

Closed
erickt opened this issue Mar 27, 2013 · 5 comments
Closed

Comments

@erickt
Copy link
Contributor

erickt commented Mar 27, 2013

I ran into an issue in #5578 where error!("...") was getting expanded into log(1, "...") instead of __log(1, "..."), which resulted in a compile error. We should add some tests that make sure we can still compile code after macros have been expanded.

@jbclements
Copy link
Contributor

To clarify: if I understand you correctly, you're saying that the expansion of error!("...") was being rendered by pprust as log(1,"..."), not that the expansion was actually incorrect. Is that correct?

First off, that would obviously be a bug in the pretty-printer, which should be fixed. The larger issue of making sure that pretty-printed code compiles I would nominate for well-covered.

@erickt
Copy link
Contributor Author

erickt commented May 24, 2013

@jbclements: Yep, that was the problem, it's fixed now though. The larger issue still stands.

@graydon
Copy link
Contributor

graydon commented Aug 15, 2013

just a bug, removing milestone/nomination.

@klutzy
Copy link
Contributor

klutzy commented May 26, 2014

Fixed by #14106!

@huonw
Copy link
Member

huonw commented May 26, 2014

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants