Tracking issue for #[ffi_const] #58328
Labels
A-FFI
Area: Foreign function interface (FFI)
B-unstable
Blocker: Implemented in the nightly compiler and unstable.
C-tracking-issue
Category: An issue tracking the progress of sth. like the implementation of an RFC
S-tracking-needs-summary
Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
T-opsem
Relevant to the opsem team
Comments
jonas-schievink
added
B-unstable
|
This corresponds to the LLVM |
Centril
added
the
T-lang
joshtriplett
added
the
S-tracking-needs-summary
|
Is this fully implemented and ready for potential stabilization, or is there any blocker? |
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 1, 2023
…twco Strengthen validation of FFI attributes Previously, `codegen_attrs` validated the attributes `#[ffi_pure]`, `#[ffi_const]`, and `#[ffi_returns_twice]` to make sure that they were only used on foreign functions. However, this validation was insufficient in two ways: 1. `codegen_attrs` only sees items for which code must be generated, so it was unable to raise errors when the attribute was incorrectly applied to macros and the like. 2. the validation code only checked that the item with the attr was foreign, but not that it was a foreign function, allowing these attributes to be applied to foreign statics as well. This PR moves the validation to `check_attr`, which sees all items. It additionally changes the validation to ensure that the attribute's target is `Target::ForeignFunction`, only allowing the attributes on foreign functions and not foreign statics. Because these attributes are unstable, there is no risk for backwards compatibility. The changes also ending up making the code much easier to read. This PR is best reviewed commit by commit. Additionally, I was considering moving the tests to the `attribute` subdirectory, to get them out of the general UI directory. I could do that as part of this PR or a follow-up, as the reviewer prefers. CC: rust-lang#58328, rust-lang#58329
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Annotates an extern C function with C
constattribute.https://doc.rust-lang.org/beta/unstable-book/language-features/ffi-const.html
The text was updated successfully, but these errors were encountered: