Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming is broken on Arch Linux after LLVM upgrade #5835

Closed
brson opened this issue Apr 11, 2013 · 5 comments
Closed

Incoming is broken on Arch Linux after LLVM upgrade #5835

brson opened this issue Apr 11, 2013 · 5 comments
Assignees
@brson

Comments

@brson
Copy link
Contributor

brson commented Apr 11, 2013

https://gist.github.com/Jeaye/c98b280b5ca9055ed114

I did drop our patch to fix python detection, thinking it was fixed upstream. It appears not to be and reapplying our patch to fix python detection does not appear to fix the problem.
@ghost ghost assigned brson Apr 11, 2013
@brson
Copy link
Contributor Author

brson commented Apr 11, 2013

It may not be related to python. Could just be failing in the vicinity of the python test.

@thestinger
Copy link
Contributor

@brson: the way I end up dealing with this is making a temp directory and putting another python symlink in PATH with it. So perhaps Rust could detect if python is python3 or if only python2 exists and do that before it builds LLVM. That would avoid needing to patch LLVM too.

https://github.com/thestinger/packages/blob/master/cling-svn/PKGBUILD#L21

It looks like LLVM has a PYTHON variable in Makefile.config.in, so perhaps Rust could be using that somehow.

@brendanzab
Copy link
Member

I can confirm that this also occurs in OS X.

@brendanzab
Copy link
Member

Switching to python 2.7 seemed to allow it to build - I was on python 3.3. For those using MacPorts: sudo port select python python27.

brson added a commit to brson/rust that referenced this issue Apr 11, 2013
@brson
Pass the value of python to LLVM's configure script. rust-lang#5835
62c94d3
@brson
Copy link
Contributor Author

brson commented Apr 13, 2013

Fixed.

@brson brson closed this as completed Apr 13, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
@bors
Auto merge of rust-lang#7039 - phansch:melt-ice, r=flip1995
24921df 
tabs_in_doc_comments: Fix ICE due to char indexing

This is a quick-fix for an ICE in `tabs_in_doc_comments`. The problem
was that we we're indexing into possibly multi-byte characters, such as '位'.

More specifically `get_chunks_of_tabs` was returning indices into
multi-byte characters. Those were passed on to a `Span` creation that
then caused the ICE.

This fix makes sure that we don't return indices that point inside a
multi-byte character. *However*, we are still iterating over unicode
codepoints, not grapheme clusters. So a seemingly single character like y̆ ,
which actually consists of two codepoints, will probably still cause
incorrect spans in the output. But I don't think we handle those cases
anywhere in Clippy currently?

Fixes rust-lang#5835

changelog: Fix ICE in `tabs_in_doc_comments`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @brendanzab @thestinger