Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include llvm-ar with llvm-tools #58663

Closed
nhynes opened this issue Feb 23, 2019 · 0 comments
Closed

Include llvm-ar with llvm-tools #58663

nhynes opened this issue Feb 23, 2019 · 0 comments
Labels
O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@nhynes
Copy link
Contributor

nhynes commented Feb 23, 2019 •
edited
Loading

GNU ar doesn't support Wasm and different major versions of llvm-ar tend not to be compatible.
@Centril Centril added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 23, 2019
@phil-opp phil-opp mentioned this issue Mar 21, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 28, 2019
@Centril
Rollup merge of rust-lang#59351 - phil-opp:llvm-ar, r=alexcrichton
e04b7b8 
Include llvm-ar with llvm-tools component

Adds the `llvm-ar` tool to the `llvm-tools` component. This is useful for [building and linking native code](https://doc.rust-lang.org/cargo/reference/build-scripts.html#case-study-building-some-native-code) in cargo build scripts without needing to use the platform specific `ar`. According to rust-lang#58663 it is also useful for WASM.

 `llvm-ar` is very small (~82KB), so it does not significantly increase the size of the `llvm-tools` component.

Fixes rust-lang#58663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-wasm Target: WASM (WebAssembly), http://webassembly.org/ T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Centril @nhynes