Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE with #![feature(existential_type)] + closure #58951

Closed
Centril opened this issue Mar 5, 2019 · 4 comments · Fixed by #63158
Closed

ICE with #![feature(existential_type)] + closure #58951

Centril opened this issue Mar 5, 2019 · 4 comments · Fixed by #63158
Labels
A-closures Area: Closures (`|…| { … }`) A-impl-trait Area: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch. A-typesystem Area: The type system E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Mar 5, 2019

Encountered this when working on test cases for an RFC:

#![feature(existential_type)]

existential type A: Iterator;
fn def_a() -> A { 0..1 }
pub fn use_a() {
    def_a().map(|x| x);
}

cc @oli-obk

This seems related to other issues.
@Centril Centril added A-typesystem Area: The type system I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ A-closures Area: Closures (`|…| { … }`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-impl-trait Area: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch. labels Mar 5, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2019

I'm confused. Either this was fixed since yesterday's nightly (it still ICEs on nightly but works locally on master), or something really odd is going on

@Centril
Copy link
Contributor Author

Centril commented Mar 18, 2019

@oli-obk Is that the upstream master? Otherwise maybe someone merged a PR or something..

@Centril
Copy link
Contributor Author

Centril commented Apr 3, 2019

This still ICEs on nightly.

@Centril Centril added F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` requires-nightly This issue requires a nightly compiler in some way. labels Jul 28, 2019
@Aaron1011
Copy link
Member

This now compiles successfully on the latest nightly.

@Centril Centril added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Jul 30, 2019
@JohnTitor JohnTitor mentioned this issue Jul 31, 2019
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 1, 2019
@pietroalbini
Rollup merge of rust-lang#63158 - JohnTitor:add-test-for-58951, r=Cen…
aaec6df 
…tril

Add test for issue-58951

Closes rust-lang#58951

r? @Centril
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-closures Area: Closures (`|…| { … }`) A-impl-trait Area: `impl Trait`. Universally / existentially quantified anonymous types with static dispatch. A-typesystem Area: The type system E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
type alias impl trait stabilization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for issue-58951 JohnTitor/rust
3 participants
@oli-obk @Centril @Aaron1011